Add groups based on observed usage in knative repos#552
Merged
Conversation
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
do-not-merge/invalid-owners-file
Member
Author
|
/verify-owners |
knative-prow-robot
removed
the
do-not-merge/invalid-owners-file
Member
Author
|
/retest |
This was referenced Mar 31, 2021
Member
Author
|
/assign @vaikas (For |
This was referenced Apr 1, 2021
dprotaso
requested changes
Apr 6, 2021
| description: Approvers for configmap utilities in pkg | ||
| privacy: closed | ||
| members: | ||
| - grantr |
dprotaso
reviewed
Apr 6, 2021
| - whaught | ||
| teams: | ||
| Pkg Controller Writers: | ||
| description: Approvers for configmap utilities in pkg |
Member
There was a problem hiding this comment.
typo
Suggested change
| description: Approvers for configmap utilities in pkg | |
| description: Approvers for controller utilities in pkg |
vaikas
approved these changes
Apr 7, 2021
Contributor
vaikas
left a comment
vaikas
left a comment
There was a problem hiding this comment.
/lgtm
/hold
just adding a hold in case others want to chime in. Remove as y'all see fit.
knative-prow-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
/lgtm , too |
Member
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(PRs incoming shortly for each repo to use the groups defined here.)
Note that I did not preserve all groups that existing in each OWNERS_ALIASES file. I also needed to create several groups, and split up
Serving Writersinto Working Group based groups.My criteria for creating groups in peribolos was:
Note that I did not try to rationalize much of the existing files, simply to migrate them to OWNERS_ALIASES
Another change which hasn't yet been done is adding in the "release leads" rotation. I expect to do that during this week, but since Markus and I have TOC approvers in most repos, I don't expect this to be a speedbump for 0.22