Skip to content

Update OWNERS_ALIASES to match autogen in community#25

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
evankanderson:owner-gen
Apr 8, 2021
Merged

Update OWNERS_ALIASES to match autogen in community#25
knative-prow-robot merged 1 commit into
knative:mainfrom
evankanderson:owner-gen

Conversation

@evankanderson
Copy link
Copy Markdown
Member

See knative/community#552 for the addition of groups/full OWNERS_ALIASES that will be synced.

This is a preparatory PR for landing OWNERS_ALIASES automation across the Knative org (alternative to the CODEOWNERS changes in knative-sandbox).

If this seems to be expanding permissions or otherwise likely to cause a problem, /hold this PR and comment here or on knative/community#552.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 1, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2021
@evankanderson
Copy link
Copy Markdown
Member Author

/assign @rhuss

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Apr 8, 2021

Looks good, except that Naomi is not part anymore, but I suspect that the OWNER_ALIASES will be updated/overwritten by the automation soon anyway, so fine with it now.

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Apr 8, 2021

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
@knative-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@knative-prow-robot knative-prow-robot merged commit 9ffaa66 into knative:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants