drop use of upstream knative.dev/pkg/metric eventing keys#5586
Merged
knative-prow-robot merged 3 commits intoJul 12, 2021
Conversation
knative-prow-robot
added
size/L
Codecov Report
@@ Coverage Diff @@
## main #5586 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 198 198
Lines 6172 6172
=======================================
Hits 5102 5102
Misses 743 743
Partials 327 327
Continue to review full report at Codecov.
|
n3wscott
reviewed
Jul 12, 2021
| @@ -0,0 +1,65 @@ | |||
| /* | |||
| Copyright 2020 The Knative Authors | |||
n3wscott
approved these changes
Jul 12, 2021
Contributor
n3wscott
left a comment
n3wscott
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
hold for nit on date.
knative-prow-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
dprotaso
added a commit
to dprotaso/pkg
that referenced
this pull request
Jul 14, 2021
We're going to move the StatsReporter downstream eventually related: knative/eventing#5587 knative/eventing#5586
knative-prow-robot
pushed a commit
to knative/pkg
that referenced
this pull request
Jul 14, 2021
* drop stack driver as a tracing backend * drop stackdriver as a metrics backend * update deps - dropping stackdriver * fix linting issues * drop further references to stack driver * drop serving & eventing metric key constants these have been moved to their respective repos see: #608 * move source metrickeys to pkg/source We're going to move the StatsReporter downstream eventually related: knative/eventing#5587 knative/eventing#5586 * fix linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: knative/pkg#608
Proposed Changes
Pre-review Checklist
- [ ] At least 80% unit test coverageN/A- [ ] E2E tests for any new behaviorN/A- [ ] Docs PR for any user-facing impactN/A- [ ] Spec PR for any new API featureN/A- [ ] Conformance test for any change to the spec- N/ARelease Note
Docs