Move knative.dev/pkg/source.StatsReporter to eventing/pkg/metrics/source.StatsReporting - 1/n#5587
Conversation
|
/assign @n3wscott |
|
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #5587 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 198 198
Lines 6172 6172
=======================================
Hits 5102 5102
Misses 743 743
Partials 327 327
Continue to review full report at Codecov.
|
|
Going to do this in three passes
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Something's up with GKE |
We're going to move the StatsReporter downstream eventually related: knative/eventing#5587 knative/eventing#5586
* drop stack driver as a tracing backend * drop stackdriver as a metrics backend * update deps - dropping stackdriver * fix linting issues * drop further references to stack driver * drop serving & eventing metric key constants these have been moved to their respective repos see: #608 * move source metrickeys to pkg/source We're going to move the StatsReporter downstream eventually related: knative/eventing#5587 knative/eventing#5586 * fix linter
Part of: knative/pkg#608
tl;dr I'm moving
metrickeysthat are specific to a subproject out ofknative.dev/pkg. Metrickeys for sources were moved to here: #5586 this moves the upstream (knative.dev/pkg/source) StatsReporter to this repo as well.Why land this in knative/eventing?
I looked at pkg.go.dev and imports of
knative.dev/pkg/sourceandknative.dev/pkg/metrics/metricskeyis fairly minimal. All the imports I saw also pull inknative.dev/eventingthus I opt to land it here.I'll only need to update the following repos after this PR merges
Proposed Changes
Release Note
Docs