Skip to content

move source.StatsReporter from knative.dev/pkg#5594

Merged
knative-prow-robot merged 2 commits into
knative:mainfrom
dprotaso:move-stats-reporter
Jul 14, 2021
Merged

move source.StatsReporter from knative.dev/pkg#5594
knative-prow-robot merged 2 commits into
knative:mainfrom
dprotaso:move-stats-reporter

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jul 14, 2021

Part of: knative/pkg#608

Part two of #5587

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 14, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2021
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jul 14, 2021

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2021

Codecov Report

Merging #5594 (1bb099c) into main (0af15fd) will increase coverage by 0.08%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5594      +/-   ##
==========================================
+ Coverage   82.71%   82.79%   +0.08%     
==========================================
  Files         198      199       +1     
  Lines        6177     6230      +53     
==========================================
+ Hits         5109     5158      +49     
- Misses        742      744       +2     
- Partials      326      328       +2     
Impacted Files Coverage Δ
pkg/metrics/source/stats_reporter.go 92.45% <92.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af15fd...1bb099c. Read the comment docs.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 14, 2021

Could we get over the 80% UT bar that we're targeting with all PRs prior to v1.

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/metrics/source/stats_reporter.go Do not exist 89.5%

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 14, 2021

/test pull-knative-eventing-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 14, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants