remove source stats reporter it's been moved to knative.dev/eventing/pkg/metrics/source#2193
Conversation
it's been moved to knative.dev/eventing/pkg/metrics/source
Codecov Report
@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 67.58% 66.04% -1.54%
==========================================
Files 215 220 +5
Lines 9098 9204 +106
==========================================
- Hits 6149 6079 -70
- Misses 2675 2856 +181
+ Partials 274 269 -5
Continue to review full report at Codecov.
|
|
I guess we need to create downstream PRs as well? |
|
Yup that's already done: Transition PR using type aliases: Adopt new package: Move the code over |
|
Even though: knative-extensions/eventing-rabbitmq#362 is in, the downstream for it is failing? |
|
I think those downstream deps don't have the latest eventing deps - let me check |
|
/hold I'll do the rounds and approve those update deps PRs |
|
/hold cancel ok all downstream repos have the latest eventing dep update which causes everything here to go green |
|
Thanks @dprotaso |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #608