Skip to content

remove source stats reporter it's been moved to knative.dev/eventing/pkg/metrics/source#2193

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
dprotaso:drop-source-statsreporter
Jul 15, 2021
Merged

remove source stats reporter it's been moved to knative.dev/eventing/pkg/metrics/source#2193
knative-prow-robot merged 1 commit into
knative:mainfrom
dprotaso:drop-source-statsreporter

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jul 15, 2021

Fixes: #608

it's been moved to knative.dev/eventing/pkg/metrics/source
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 15, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2021

Codecov Report

Merging #2193 (5d96302) into main (00fa154) will decrease coverage by 1.53%.
The diff coverage is 70.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
- Coverage   67.58%   66.04%   -1.54%     
==========================================
  Files         215      220       +5     
  Lines        9098     9204     +106     
==========================================
- Hits         6149     6079      -70     
- Misses       2675     2856     +181     
+ Partials      274      269       -5     
Impacted Files Coverage Δ
.../injection-gen/generators/reconciler_controller.go 0.00% <ø> (ø)
leaderelection/config.go 77.27% <ø> (ø)
logging/warning_handler.go 0.00% <0.00%> (ø)
metrics/config_observability.go 92.00% <ø> (ø)
test/cleanup.go 0.00% <0.00%> (ø)
test/clients.go 0.00% <ø> (ø)
test/request.go 0.00% <0.00%> (ø)
test/spoof/error_checks.go 76.92% <0.00%> (-6.42%) ⬇️
tracing/opencensus.go 46.26% <ø> (+3.21%) ⬆️
injection/clients/dynamicclient/fake/fake.go 64.28% <50.00%> (-35.72%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7764284...5d96302. Read the comment docs.

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Jul 15, 2021

I guess we need to create downstream PRs as well?

@dprotaso
Copy link
Copy Markdown
Member Author

Yup that's already done:

Transition PR using type aliases:
knative/eventing#5587

Adopt new package:
knative-extensions/eventing-rabbitmq#362
knative-extensions/eventing-kafka#765

Move the code over
knative/eventing#5594

@dprotaso
Copy link
Copy Markdown
Member Author

/assign @vaikas @n3wscott

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 15, 2021

Even though: knative-extensions/eventing-rabbitmq#362 is in, the downstream for it is failing?
Also looks like bunch of other tests are failing also.

@dprotaso
Copy link
Copy Markdown
Member Author

I think those downstream deps don't have the latest eventing deps - let me check

@dprotaso
Copy link
Copy Markdown
Member Author

/hold
ie. Yeah this needs to merge: knative-extensions/eventing-rabbitmq#363

I'll do the rounds and approve those update deps PRs

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@dprotaso
Copy link
Copy Markdown
Member Author

/hold cancel

ok all downstream repos have the latest eventing dep update which causes everything here to go green

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 15, 2021

Thanks @dprotaso
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 8931f82 into knative:main Jul 15, 2021
@dprotaso dprotaso deleted the drop-source-statsreporter branch July 15, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove serving/eventing StackDriver specific metrics

5 participants