Skip to content

Remove the Source CRD, as decided in https://github.com/knative/eventing/pull/482#559

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:delete-source
Oct 25, 2018
Merged

Remove the Source CRD, as decided in https://github.com/knative/eventing/pull/482#559
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:delete-source

Conversation

@adamharwayne
Copy link
Copy Markdown
Contributor

@adamharwayne adamharwayne commented Oct 24, 2018 •
edited
Loading

Remove the Source CRD, as decided in #482.

Related to #542

Proposed Changes

  • Delete the Source CRD.

Release Note

You will need to manually delete the existing CRD, if already installed:
    kubectl delete crd sources.eventing.knative.dev

If you are using a Source ClusterProvisioner, it will need to be migrated to a CRD.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 24, 2018
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2018
@adamharwayne
Copy link
Copy Markdown
Contributor Author

adamharwayne commented Oct 24, 2018

/assign @grantr

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Oct 24, 2018

😢
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamharwayne, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@knative-prow-robot knative-prow-robot merged commit 8d636fb into knative:master Oct 25, 2018
@Harwayne Harwayne deleted the delete-source branch January 29, 2019 22:45
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 11, 2024
@creydr
Add owning-component annotation to config-openshift-trusted-cabundle …
77cba19 
…ConfigMap (knative#559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scothis scothis Awaiting requested review from scothis

1 more reviewer

@grantr grantr grantr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adamharwayne @n3wscott @knative-prow-robot @grantr @googlebot @Harwayne