Adding Knative Eventing Object Model targeting 0.1 release. by n3wscott · Pull Request #482 · knative/eventing

n3wscott · 2018-10-01T16:52:51Z

Adding https://docs.google.com/document/d/1JZtFkz_C3orG9IfDxxGkAmuuGxUQ434ji-rdl3oKObE/edit to the repo as a markdown file.

Release Note

NONE

googlebot · 2018-10-22T19:46:48Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

grantr · 2018-10-22T20:44:08Z

Authors and co-authors @evankanderson @n3wscott @scothis @matzew have all accepted the CLA on other PRs. Manually setting CLA to yes.

evankanderson

/lgtm
/approve

Missed these yesterday, but this looks close enough to go in.

evankanderson · 2018-10-22T18:09:02Z

+
+##### Conditions
+
+- **Ready.**


At least 9 forward, and the 10th which is not Ready may or may not forward.

evankanderson · 2018-10-22T18:09:46Z

+- **CallActive.** True if the call is sinking events without error.
+- **Resolved.**
+
+#### Events


That's why I wonder if removing these Events would make it easier to read the spec without losing any utility.

evankanderson · 2018-10-22T18:22:11Z

+
+| Field | Type            | Description | Limitations |
+| ----- | --------------- | ----------- | ----------- |
+| ref\* | ObjectReference |             |             |


ProvisionerReference is only used in Channel's spec. Compare:

apiVersion: eventing.knative.dev/v1alpha1 kind: Channel metadata: name: cc-payments spec: provisioner: apiVersion: eventing.knative.dev/v1alpha1 kind: ClusterChannelProvisioner name: kafka

vs

apiVersion: eventing.knative.dev/v1alpha1 kind: Channel metadata: name: cc-payments spec: provisioner: clusterName: kafka # Allows for name later

I have a slight preference for the smaller and simpler format, since we don't really want to distinguish between more than two possible types (ChannelProvisioner and ClusterChannelProvisioner).

knative-prow-robot · 2018-10-23T17:23:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot · 2018-10-23T17:32:14Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

* Change Channelable to match the definition in #482. * No longer use the subscribable interface. * Move the Channelable duck type into the eventing repo.

Co-authored-by: Paul Morie <pmorie@redhat.com>

First port of spec doc to markdown.

d89a84e

knative-prow-robot requested review from grantr and scothis October 1, 2018 16:52

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 1, 2018

n3wscott changed the title ~~object model spec doc to markdown.~~ [WIP] object model spec doc to markdown. Oct 1, 2018

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2018

Scott Nichols added 4 commits October 1, 2018 09:57

trim unused objects.

f0930b9

start using mrkdown tables.

1e1607a

more meta for tables.

0558eab

passed at making tables md style.

f0fdc69

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 1, 2018

Scott Nichols added 8 commits October 1, 2018 10:30

Adding formatting to the markdown tables.

e5d8eaa

minor formatting.

ffaea55

Make required clear.

69eb6de

Adding links.

9b977cf

add spacing because markdown.

469ea51

Explode out the spec into components.

eb401b9

Added images.

bf16902

Adding a link back to the original image to allow for editing later.

6adb9f0

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2018

Scott Nichols added 6 commits October 1, 2018 11:37

adding nav links to the bottom.

edf5caf

next should not have this page.

7ca20b8

Fix interface image.

9c825b8

scrub flow.

806e9a1

fix image and update some bolds.

743b164

Trying to make the documents read better.

f7689d0

n3wscott changed the title ~~[WIP] object model spec doc to markdown.~~ Adding object model spec doc to markdown. Oct 1, 2018

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2018

grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 22, 2018

evankanderson reviewed Oct 23, 2018

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018

grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 23, 2018

googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 23, 2018

googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 23, 2018

knative-prow-robot merged commit b6219ae into knative:master Oct 23, 2018

This was referenced Oct 23, 2018

Documentation: Documented spec #368

Closed

Update Interfaces to match spec #542

Closed

adamharwayne pushed a commit to Harwayne/knative-eventing that referenced this pull request Oct 23, 2018

Change Channelable to match the definition in knative#482.

a14a315

adamharwayne pushed a commit to Harwayne/knative-eventing that referenced this pull request Oct 23, 2018

Change Channelable to match the definition in knative#482.

139284e

adamharwayne pushed a commit to Harwayne/knative-pkg that referenced this pull request Oct 23, 2018

Make Channelable match the definition in knative/eventing#482.

b9989a4

adamharwayne mentioned this pull request Oct 24, 2018

Make Channelable match the definition in https://github.com/knative/eventing/pull/482. knative/pkg#134

Merged

adamharwayne pushed a commit to Harwayne/knative-eventing that referenced this pull request Oct 24, 2018

Remove the Source CRD, as decided in knative#482.

8536a40

This was referenced Oct 24, 2018

Remove the Source CRD, as decided in https://github.com/knative/eventing/pull/482 #559

Merged

Change the Channelable interface to use URIs. #561

Merged

knative-prow-robot pushed a commit that referenced this pull request Oct 25, 2018

Remove the Source CRD, as decided in #482. (#559)

8d636fb

knative-prow-robot pushed a commit to knative/pkg that referenced this pull request Oct 26, 2018

Make Channelable match the definition in knative/eventing#482. (#134)

79a0998

matzew mentioned this pull request Oct 10, 2019

Adding matzew to approvers #2033

Merged

matzew added a commit to matzew/eventing that referenced this pull request Mar 11, 2020

Update to latest pkg 0.13 (knative#2727) (knative#482)

97407c5

Co-authored-by: Paul Morie <pmorie@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Knative Eventing Object Model targeting 0.1 release.#482

Adding Knative Eventing Object Model targeting 0.1 release.#482
knative-prow-robot merged 68 commits into
knative:masterfrom
n3wscott:push_raw_spec

n3wscott commented Oct 1, 2018

Uh oh!

googlebot commented Oct 22, 2018

Uh oh!

grantr commented Oct 22, 2018

Uh oh!

evankanderson left a comment

Uh oh!

evankanderson Oct 22, 2018

Uh oh!

evankanderson Oct 22, 2018

Uh oh!

evankanderson Oct 22, 2018

Uh oh!

knative-prow-robot commented Oct 23, 2018

Uh oh!

googlebot commented Oct 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

n3wscott commented Oct 1, 2018

Uh oh!

googlebot commented Oct 22, 2018

Uh oh!

grantr commented Oct 22, 2018

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

evankanderson Oct 22, 2018

Choose a reason for hiding this comment

Uh oh!

evankanderson Oct 22, 2018

Choose a reason for hiding this comment

Uh oh!

evankanderson Oct 22, 2018

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Oct 23, 2018

Uh oh!

googlebot commented Oct 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants