Skip to content

Change the Channelable interface to use URIs.#561

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
Harwayne:uri
Oct 25, 2018
Merged

Change the Channelable interface to use URIs.#561
knative-prow-robot merged 4 commits into
knative:masterfrom
Harwayne:uri

Conversation

@adamharwayne
Copy link
Copy Markdown
Contributor

@adamharwayne adamharwayne commented Oct 24, 2018

Another piece of #542.

Proposed Changes

  • Stop using the knative/pkg's Channelable duck type. Instead make our own in this repo.
    • I elected to continue with a duck Channelable, rather than just using eventing's Channel, because we have already done the work to make the duck portion work in the Subscription controller and believe that we might want this feature post 0.1.
  • Change Channelable to use URIs, rather than domains. As specified in Adding Knative Eventing Object Model targeting 0.1 release. #482.

Release Note

You will need to rebuild and deploy:

1. Delete ALL existing Channels.
    kubectl get channels.eventing; kubectl delete channels.eventing ...
2. Any Channel ClusterProvisioners.
    kubectl get clusterprovisioners; kubectl delete clusterprovisioner ...
3. The main eventing controller.
    ko apply -f config/500-controller.yaml
4. The main eventing webhook.
    ko apply -f config/500-webhook.yaml
5. The Channel CRD.
    ko apply -f config/300-channeleventing.yaml

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2018
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 24, 2018
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2018
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2018
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/channelable_types.go Do not exist 0.0%
pkg/controller/eventing/subscription/reconcile.go 77.8% 78.0% 0.3

@adamharwayne adamharwayne changed the title [WIP] Change the Channelable interface to use URIs. Change the Channelable interface to use URIs. Oct 25, 2018
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2018
@adamharwayne
Copy link
Copy Markdown
Contributor Author

/assign @evankanderson

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamharwayne, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@knative-prow-robot knative-prow-robot merged commit 5d73d6e into knative:master Oct 25, 2018
@Harwayne Harwayne deleted the uri branch January 29, 2019 22:45
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants