Skip to content

Align ClusterChannelProvisioner with spec#562

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
scothis:cluster-channel-provisioner
Oct 26, 2018
Merged

Align ClusterChannelProvisioner with spec#562
knative-prow-robot merged 4 commits into
knative:masterfrom
scothis:cluster-channel-provisioner

Conversation

@scothis
Copy link
Copy Markdown
Contributor

@scothis scothis commented Oct 24, 2018 •
edited
Loading

Proposed Changes

  • rename ClusterProvisioner to ClusterChannelProvisioner (the only provisioned resource is a Channel)
  • remove Reconciles field since the only resource that can be reconciled is a Channel

Release Note

This only affects clusters that have already installed ClusterProvisioners.

1. Delete any existing ClusterProvisioners
    kubectl get clusterprovisioners
    kubectl delete clusterprovisioners

2. Redeploy the in-memory Channel Controller and ClusterChannelProvisioner.
    ko apply -f config/provisioners/in-memory-channel/in-memory-channel.yaml

/assign @adamharwayne

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 24, 2018
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 24, 2018
@scothis scothis mentioned this pull request Oct 24, 2018
Merged
vaikas
vaikas reviewed Oct 25, 2018
View reviewed changes
Comment thread pkg/controller/eventing/inmemory/clusterchannelprovisioner/reconcile.go Outdated

// IsControlled determines if the in-memory Channel Controller should control (and therefore
// reconcile) a given object, based on that object's ClusterProvisioner reference. kind is the kind
// reconcile) a given object, based on that object's ClusterChannelProvisioner reference. kind is the kind
Copy link
Copy Markdown
Contributor

@vaikas vaikas Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last sentence: kind is the kind... is no longer relevant.

Copy link
Copy Markdown
Contributor Author

@scothis scothis Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed :)

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Oct 25, 2018

/lgtm

/hold

holding for Ville's comment.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 25, 2018
@adamharwayne
Copy link
Copy Markdown
Contributor

adamharwayne commented Oct 25, 2018

/lgtm

We should probably add some release notes:

This only affects clusters that have already installed ClusterProvisioners.

1. Delete any existing ClusterProvisioners
    kubectl get clusterprovisioners
    kubectl delete clusterprovisioners

2. Redeploy the in-memory Channel Controller and ClusterChannelProvisioner.
    ko apply -f config/provisioners/in-memory-channel/in-memory-channel.yaml

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 25, 2018

@scothis I'll approve, but please fix the comment in a follow on PR?
/lgtm
/approve

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@scothis
Copy link
Copy Markdown
Contributor Author

scothis commented Oct 26, 2018

Addressed review feedback, updated release notes and fixed conflicts.

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Oct 26, 2018

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/cluster_channel_provisioner_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/cluster_channel_provisioner_types.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/cluster_channel_provisioner_validation.go Do not exist 100.0%

@matzew
Copy link
Copy Markdown
Member

matzew commented Oct 26, 2018

👍

@matzew matzew mentioned this pull request Oct 26, 2018
Merged
@adamharwayne
Copy link
Copy Markdown
Contributor

adamharwayne commented Oct 26, 2018

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 26, 2018

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scothis, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [scothis,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adamharwayne
Copy link
Copy Markdown
Contributor

adamharwayne commented Oct 26, 2018

/hold cancel
Ville's comment has been addressed.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2018
@knative-prow-robot knative-prow-robot merged commit b063fed into knative:master Oct 26, 2018
adamharwayne pushed a commit to Harwayne/knative-eventing that referenced this pull request Oct 29, 2018
@Harwayne
Update in-memory-channel.yaml to conform to the changes made in knati…
86c1682 
…ve#562.
@adamharwayne adamharwayne mentioned this pull request Oct 29, 2018
Merged
knative-prow-robot pushed a commit that referenced this pull request Oct 30, 2018
@adamharwayne @knative-prow-robot
Update in-memory-channel.yaml to conform to the changes made in #562. (…
36b0146 
…#564)
@matzew matzew mentioned this pull request Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

1 more reviewer

@vaikas vaikas vaikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adamharwayne adamharwayne

@vaikas vaikas

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@scothis @n3wscott @adamharwayne @vaikas @knative-metrics-robot @matzew @knative-prow-robot @googlebot