Skip to content

use the full name for the clusterchannelprovisioner kind CRD file#569

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:rename_clusterprovisioner_crd_file
Oct 31, 2018
Merged

use the full name for the clusterchannelprovisioner kind CRD file#569
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:rename_clusterprovisioner_crd_file

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Oct 31, 2018

Proposed Changes

  • rename the CRD yaml file for the kind: ClusterChannelProvisioner

this is a small follow up on the original #562 PR from @scothis

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 31, 2018
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2018
@scothis
Copy link
Copy Markdown
Contributor

scothis commented Oct 31, 2018

/ok-to-test
/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, scothis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@knative-prow-robot knative-prow-robot merged commit fbb9a6b into knative:master Oct 31, 2018
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Mar 14, 2024
…_1.13

[release-v1.13] Bump Go-SDK for CE to 2.15.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants