Remove v1.DeliveryStatus, which was unused outside of pkg/apis.

[evankanderson]

Related to #5364

Proposed Changes

• 🧹 Remove duckv1.DeliveryStatus, which was unused, in preparation for the replacement of deadLetterChanel with deadLetterSinkUri.

Pre-review Checklist

• At least 80% unit test coverage
• [na] E2E tests for any new behavior
• [na] Docs PR for any user-facing impact
• [na] Spec PR for any new API feature
• [na] Conformance test for any change to the spec

Release Note

- Removes the unused duck type `v1.DeliveryStatus`. `v1.DeliverySpec` remains and is used.

Docs

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[evankanderson]

/hold

I accidentally added a status change to v1.Channel that's meant for another PR.

[lionelvillard]

insteam -> instead

[evankanderson]

Yeah, this was me seeing a refactor and forgetting to stash things before doing a cleanup.

[codecov]

Codecov Report

Merging #5745 (bc4cc1d) into main (f031ba2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5745      +/-   ##
==========================================
- Coverage   82.65%   82.62%   -0.04%     
==========================================
  Files         202      202              
  Lines        6326     6312      -14     
==========================================
- Hits         5229     5215      -14     
  Misses        758      758              
  Partials      339      339              

Impacted Files	Coverage Δ
pkg/apis/duck/v1/delivery_conversion.go	100.00% <ø> (ø)
pkg/apis/duck/v1/delivery_types.go	91.66% <ø> (ø)
pkg/apis/duck/v1beta1/delivery_conversion.go	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f031ba2...bc4cc1d. Read the comment docs.

[lionelvillard]

insteam -> instead

[lionelvillard]

v1.DeliveryStatus is not used but it should be used. For instance there:

eventing/pkg/apis/duck/v1/channelable_types.go

Line 69 in f031ba2

DeadLetterChannel *duckv1.KReference `json:"deadLetterChannel,omitempty"`

and there:

eventing/pkg/apis/eventing/v1/trigger_types.go

Line 125 in f031ba2

DeadLetterSinkURI *apis.URL `json:"deadLetterSinkUri,omitempty"`

this was the original intent.

[evankanderson]

/hold cancel

[evankanderson]

Lionel preferred #5746, this one is probably moot.

/close

[knative-prow-robot]

@evankanderson: Closed this PR.

Details

In response to this:

Lionel preferred #5746, this one is probably moot.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.