Retire deadLetterChannel, use DeliveryStatus consistently#5746
Conversation
Add DeliveryStatus to Channelable.
Codecov Report
@@ Coverage Diff @@
## main #5746 +/- ##
==========================================
- Coverage 82.65% 82.62% -0.04%
==========================================
Files 202 202
Lines 6326 6314 -12
==========================================
- Hits 5229 5217 -12
Misses 758 758
Partials 339 339
Continue to review full report at Codecov.
|
|
@evankanderson do you want to get this in or add the fix you mentioned in Slack in this PR? |
|
The other spec fix is in a completely different place for a different issue (Subscription's This one is complete as is. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add DeliveryStatus to Channelable.
Fixes #5364
Proposed Changes
deadLetterSinkUrito make Channelables spec-compliant.deadLetterChannel.DeliveryStatusactually used, as suggested in Remove v1.DeliveryStatus, which was unused outside ofpkg/apis. #5745Pre-review Checklist
Release Note
Docs
No docs needed; the only mention of
deadLetterChannelis in the auto-generated docs.