Skip to content

Install source at requirement phase in conformance tests#6712

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
pierDipi:install-source-requirement-phase
Feb 1, 2023
Merged

Install source at requirement phase in conformance tests#6712
knative-prow[bot] merged 1 commit into
knative:mainfrom
pierDipi:install-source-requirement-phase

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Feb 1, 2023

We might end up sending events before triggers are ready,
so that causes to have an unspecified behaviour.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

@pierDipi
Install source at requirement phase in conformance tests
4737ae1 
We might endup sending events before triggers are ready, so
that causes to have an unspecified behaviour.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow Bot requested review from leetcope and mgencur February 1, 2023 15:28
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Feb 1, 2023
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Feb 1, 2023

/cc @gab-satchi @creydr

@knative-prow knative-prow Bot requested review from creydr and gab-satchi February 1, 2023 15:28
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Feb 1, 2023

/cherry-pick release-1.9

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 1, 2023

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gab-satchi
gab-satchi approved these changes Feb 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 91a1991 into knative:main Feb 1, 2023
@knative-prow-robot knative-prow-robot mentioned this pull request Feb 1, 2023
Merged
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 1, 2023

@pierDipi: new pull request created: #6713

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow Bot pushed a commit that referenced this pull request Feb 1, 2023
@knative-prow-robot @pierDipi
[release-1.9] Install source at requirement phase in conformance tests (
f6cce6b 
#6713)

This is an automated cherry-pick of #6712

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew pushed a commit to matzew/eventing that referenced this pull request Feb 2, 2023
@knative-prow-robot @pierDipi @matzew
[release-1.9] Install source at requirement phase in conformance tests (
fef3046 
knative#6713)

This is an automated cherry-pick of knative#6712

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@matzew matzew mentioned this pull request Feb 2, 2023
Merged
openshift-merge-robot pushed a commit to openshift-knative/eventing that referenced this pull request Feb 8, 2023
@matzew @knative-prow-robot @pierDipi
[release-1.9] Install source at requirement phase in conformance tests (
e480980 
knative#6713) (#109)

This is an automated cherry-pick of knative#6712

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@leetcope leetcope Awaiting requested review from leetcope

@creydr creydr Awaiting requested review from creydr

1 more reviewer

@gab-satchi gab-satchi gab-satchi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gab-satchi gab-satchi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierDipi @knative-prow-robot @gab-satchi