Skip to content

[release-1.9] Install source at requirement phase in conformance tests#6713

Merged
knative-prow[bot] merged 1 commit into
knative:release-1.9from
knative-prow-robot:cherry-pick-6712-to-release-1.9
Feb 1, 2023
Merged

[release-1.9] Install source at requirement phase in conformance tests#6713
knative-prow[bot] merged 1 commit into
knative:release-1.9from
knative-prow-robot:cherry-pick-6712-to-release-1.9

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #6712

We might endup sending events before triggers are ready, so
that causes to have an unspecified behaviour.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow Bot added the area/test-and-release Test infrastructure, tests or release label Feb 1, 2023
@knative-prow knative-prow Bot requested review from leetcope and mgencur February 1, 2023 16:11
@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2023
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-1.9@d46e08b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.9    #6713   +/-   ##
==============================================
  Coverage               ?   80.49%           
==============================================
  Files                  ?      236           
  Lines                  ?    12085           
  Branches               ?        0           
==============================================
  Hits                   ?     9728           
  Misses                 ?     1869           
  Partials               ?      488           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Feb 1, 2023

/test conformance-tests

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Feb 1, 2023

/retest-required

@knative-prow knative-prow Bot merged commit f6cce6b into knative:release-1.9 Feb 1, 2023
matzew pushed a commit to matzew/eventing that referenced this pull request Feb 2, 2023
knative#6713)

This is an automated cherry-pick of knative#6712

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot pushed a commit to openshift-knative/eventing that referenced this pull request Feb 8, 2023
knative#6713) (#109)

This is an automated cherry-pick of knative#6712

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants