Skip to content

Added hostnames to tls certificates#7231

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
Cali0707:hostname-fixes-in-tls-resources
Sep 14, 2023
Merged

Added hostnames to tls certificates#7231
knative-prow[bot] merged 2 commits into
knative:mainfrom
Cali0707:hostname-fixes-in-tls-resources

Conversation

@Cali0707
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 commented Sep 5, 2023

Fixes #7209

Proposed Changes

  • Add dns name to broker ingress certificate
  • Add dns name to broker filter certificate
  • Add dns name to imc dispatcher certificate

@Cali0707
Added hostnames to tls certificates
ca97823 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow Bot requested review from creydr and matzew September 5, 2023 16:01
@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Sep 5, 2023

/cc @Leo6Leo @pierDipi

@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@knative-prow knative-prow Bot requested review from Leo6Leo and pierDipi September 5, 2023 16:01
@Leo6Leo
Copy link
Copy Markdown
Member

Leo6Leo commented Sep 5, 2023

/lgtm
Thanks @Cali0707 !

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
pierDipi
pierDipi requested changes Sep 6, 2023
View reviewed changes
Comment thread config/brokers/mt-channel-broker-tls/broker-filter-tls-certificate.yaml Outdated
@knative-prow knative-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@Cali0707 @pierDipi
Update broker-filter-tls-certificate.yaml
b93c51f 
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Sep 6, 2023

/cc @pierDipi

@knative-prow knative-prow Bot requested a review from pierDipi September 6, 2023 12:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (25400fb) 77.73% compared to head (b93c51f) 77.75%.
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7231      +/-   ##
==========================================
+ Coverage   77.73%   77.75%   +0.02%     
==========================================
  Files         246      246              
  Lines       13284    13284              
==========================================
+ Hits        10326    10329       +3     
+ Misses       2435     2433       -2     
+ Partials      523      522       -1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pierDipi
pierDipi approved these changes Sep 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @Cali0707

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Sep 14, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 14, 2023

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Sep 14, 2023

/retest-required

@knative-prow knative-prow Bot merged commit ef994be into knative:main Sep 14, 2023
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 14, 2023

@pierDipi: new pull request created: #7259

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 14, 2023
Merged
Cali0707 added a commit to Cali0707/eventing that referenced this pull request Sep 14, 2023
@Cali0707 @pierDipi
Added hostnames to tls certificates (knative#7231)
de030ba 
* Added hostnames to tls certificates

Signed-off-by: Calum Murray <cmurray@redhat.com>

* Update broker-filter-tls-certificate.yaml

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@Cali0707 Cali0707 mentioned this pull request Sep 14, 2023
Merged
openshift-merge-robot pushed a commit to openshift-knative/eventing that referenced this pull request Sep 20, 2023
@Cali0707 @pierDipi
Added hostnames to tls certificates (knative#7231) (#340)
2c118f8 
* Added hostnames to tls certificates



* Update broker-filter-tls-certificate.yaml



---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@creydr creydr Awaiting requested review from creydr

@matzew matzew Awaiting requested review from matzew

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@pierDipi pierDipi

@Leo6Leo Leo6Leo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the XXXX.knative-eventing.svc as hostname

4 participants

@Cali0707 @Leo6Leo @pierDipi @knative-prow-robot