Skip to content

[release-v1.11] Added hostnames to tls certificates (#7231)#340

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.11from
Cali0707:backport-hostname-fixes-tls-certs-v1.11
Sep 20, 2023
Merged

[release-v1.11] Added hostnames to tls certificates (#7231)#340
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.11from
Cali0707:backport-hostname-fixes-tls-certs-v1.11

Conversation

@Cali0707
Copy link
Copy Markdown
Member

Backport of knative#7231

* Added hostnames to tls certificates

Signed-off-by: Calum Murray <cmurray@redhat.com>

* Update broker-filter-tls-certificate.yaml

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@openshift-ci openshift-ci Bot requested review from lberk and pierDipi September 14, 2023 14:04
@Cali0707
Copy link
Copy Markdown
Member Author

/cc @pierDipi @matzew @creydr

@openshift-ci openshift-ci Bot requested review from creydr and matzew September 14, 2023 14:04
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi changed the title Added hostnames to tls certificates (#7231) [release-v1.11] Added hostnames to tls certificates (#7231) Sep 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2c118f8 into openshift-knative:release-v1.11 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants