Skip to content

Upgrade tests account for last event being interrupted#7447

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
mgencur:upgrades_last_step_failed
Nov 20, 2023
Merged

Upgrade tests account for last event being interrupted#7447
knative-prow[bot] merged 2 commits into
knative:mainfrom
mgencur:upgrades_last_step_failed

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Nov 14, 2023

Fixes #7446

Proposed Changes

  • Fix reporting the index of the failed step
  • Record if sending the last event was interrupted. In that case, tolerate one more event on receiver side because there's no way for the sender to know if the event was successfully sent (as the sender was interrupted and can't properly wait for confirmation)

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@mgencur
Fix reporting index of the failed step
4279ba9 
The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}
@mgencur
Upgrade tests account for last event being interrupted
9cfdc56
@knative-prow knative-prow Bot added area/test-and-release Test infrastructure, tests or release size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a645f8) 76.74% compared to head (9cfdc56) 76.74%.
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7447   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files         253      253           
  Lines       13916    13916           
=======================================
  Hits        10680    10680           
  Misses       2702     2702           
  Partials      534      534

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Nov 14, 2023

/test upgrade-tests

The test is failing from time to time but the failure doesn't look related to my changes.

matzew
matzew approved these changes Nov 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@knative-prow knative-prow Bot merged commit 140482e into knative:main Nov 20, 2023
mgencur added a commit to mgencur/eventing that referenced this pull request Nov 20, 2023
@mgencur
Upgrade tests account for last event being interrupted (knative#7447)
1a6801e 
* Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}

* Upgrade tests account for last event being interrupted
mgencur added a commit to mgencur/eventing that referenced this pull request Nov 20, 2023
@mgencur
Upgrade tests account for last event being interrupted (knative#7447)
0626a94 
* Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}

* Upgrade tests account for last event being interrupted
openshift-merge-bot Bot pushed a commit to openshift-knative/eventing that referenced this pull request Dec 7, 2023
@mgencur
Upgrade tests account for last event being interrupted (knative#7447) (…
8d94fb6 
…#429)

* Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}

* Upgrade tests account for last event being interrupted
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Dec 7, 2023
@mgencur
Upgrade tests account for last event being interrupted (knative#7447)
660d690 
* Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}

* Upgrade tests account for last event being interrupted
openshift-merge-bot Bot pushed a commit to openshift-knative/eventing that referenced this pull request Jan 2, 2024
@openshift-cherrypick-robot @mgencur
Upgrade tests account for last event being interrupted (knative#7447) (…
33dfdce 
…#458)

* Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}

* Upgrade tests account for last event being interrupted

Co-authored-by: Martin Gencur <mgencur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

An event sent during upgrade test shutdown might be actually delivered

2 participants

@mgencur @matzew