Skip to content

Upgrade tests account for last event being interrupted (#7447)#429

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.11from
mgencur:last_event_interrupted_v1.11
Dec 7, 2023
Merged

Upgrade tests account for last event being interrupted (#7447)#429
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.11from
mgencur:last_event_interrupted_v1.11

Conversation

@mgencur
Copy link
Copy Markdown

@mgencur mgencur commented Nov 20, 2023

Backport from upstream.

  • Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending step event #16691 to
"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""} {"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could not send step event 16690, retrying (1): Post
"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp 172.30.99.91:80: connect: connection refused"}

  • Upgrade tests account for last event being interrupted

* Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}

* Upgrade tests account for last event being interrupted
@openshift-ci openshift-ci Bot requested review from aliok and lberk November 20, 2023 12:44
@mgencur
Copy link
Copy Markdown
Author

mgencur commented Nov 20, 2023

/cherry-pick release-v1.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mgencur: once the present PR merges, I will cherry-pick it on top of release-v1.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Copy Markdown
Author

mgencur commented Nov 20, 2023

@matzew please review, similar to the upstream one.

@mgencur
Copy link
Copy Markdown
Author

mgencur commented Nov 20, 2023

/test 413-test-e2e-aws-ocp-413

@mgencur
Copy link
Copy Markdown
Author

mgencur commented Nov 20, 2023

/test 413-test-reconciler-aws-ocp-413

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member

matzew commented Dec 7, 2023

@mgencur do you want to cherryp pick that to 1.12 too?

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 1adeee3 and 2 for PR HEAD 0626a94 in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 5c89513 and 1 for PR HEAD 0626a94 in total

@openshift-merge-bot openshift-merge-bot Bot merged commit 8d94fb6 into openshift-knative:release-v1.11 Dec 7, 2023
@openshift-cherrypick-robot
Copy link
Copy Markdown

@mgencur: new pull request created: #458

Details

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants