Generalize description of EventType in CRD.#7617
Merged
knative-prow[bot] merged 1 commit intoJan 24, 2024
Merged
Conversation
EventType is now compatible with other resources as well, not just Broker.
knative-prow
Bot
added
the
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7617 +/- ##
=======================================
Coverage 74.43% 74.43%
=======================================
Files 262 262
Lines 15058 15058
=======================================
Hits 11209 11209
Misses 3247 3247
Partials 602 602 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
Contributor
Author
|
/test reconciler-tests |
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Jan 24, 2024
Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker.
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Jan 25, 2024
Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker.
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Jan 29, 2024
Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker.
openshift-merge-bot Bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jan 29, 2024
* Added rekt test for channel event autocreate (knative#7198) Signed-off-by: Calum Murray <cmurray@redhat.com> * Move eventtype rekttest pingsource to experiment (knative#7180) * Fix the merge conflict and fix the logical error in the test Signed-off-by: Leo Li <leoli@redhat.com> * Add the auto eventType creation support Signed-off-by: Leo Li <leoli@redhat.com> * reformat and remove the comments Signed-off-by: Leo Li <leoli@redhat.com> * Remove the assertReference function Signed-off-by: Leo Li <leoli@redhat.com> * fix reviewDog issue Signed-off-by: Leo Li <leoli@redhat.com> * Update test/rekt/resources/eventtype/eventtype.go Co-authored-by: Calum Murray <cmurray@redhat.com> * fix reviewDog issue Signed-off-by: Leo Li <leoli@redhat.com> * Move the test to experimental rekt Signed-off-by: Leo Li <leoli@redhat.com> * Remove the eventtype test from the pingsource rekt test Signed-off-by: Leo Li <leoli@redhat.com> * Rename the test name to make it more intuitive Signed-off-by: Leo Li <leoli@redhat.com> * Revert the unit test change Signed-off-by: Leo Li <leoli@redhat.com> * Format fix Signed-off-by: Leo Li <leoli@redhat.com> * format fix Signed-off-by: Leo Li <leoli@redhat.com> * Fix Christoph's comment Signed-off-by: Leo Li <leoli@redhat.com> * go imports Signed-off-by: Leo Li <leoli@redhat.com> * Update test/experimental/features/eventtype_autocreation/eventtype.go Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Update test/experimental/eventtype_autocreation_test.go Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Apply suggestions from code review Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Change the name of the file Signed-off-by: Leo Li <leoli@redhat.com> * Update the deprecated string Signed-off-by: Leo Li <leoli@redhat.com> * Update test/rekt/features/pingsource/features.go Co-authored-by: Calum Murray <cmurray@redhat.com> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <leoli@redhat.com> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <leoli@redhat.com> --------- Signed-off-by: Leo Li <leoli@redhat.com> Co-authored-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> * Added rekt test for broker eventtype autocreate (knative#7202) Signed-off-by: Calum Murray <cmurray@redhat.com> * change the deprecated string (knative#7179) * change the deprecated string * Apply suggestions from code review Co-authored-by: Calum Murray <cmurray@redhat.com> --------- Co-authored-by: Calum Murray <cmurray@redhat.com> * rekt test to verify only one EventType created for MTBroker (knative#7586) fix: eventtype autocreate for broker asserts that only one et is created Signed-off-by: Calum Murray <cmurray@redhat.com> * Generalize description of EventType in CRD. (knative#7617) Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker. * Scripts for executing experimental reconciler tests * Revert "change the deprecated string (knative#7179)" This reverts commit 7659227. * Revert "Move eventtype rekttest pingsource to experiment (knative#7180)" This reverts commit c8d12c3. * Revert "rekt test to verify only one EventType created for MTBroker (knative#7586)" This reverts commit 4eac230. * Revert "Revert "change the deprecated string (knative#7179)"" This reverts commit e469414. * Use sources.ApiServerSourceEventResourceModeTypes for ApiServerSource * Clean up imports --------- Signed-off-by: Calum Murray <cmurray@redhat.com> Signed-off-by: Leo Li <leoli@redhat.com> Co-authored-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Leo Li <leoli@redhat.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Iqbal H <52209787+Iiqbal2000@users.noreply.github.com>
openshift-merge-bot Bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jan 29, 2024
* Generalize description of EventType in CRD. (knative#7617) Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker. * Scripts for executing experimental reconciler tests * Fix script_dir path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventType is now compatible with other resources as well, not just Broker.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs