Backport EventType auto-create tests for Broker and Channel#510
Merged
openshift-merge-bot[bot] merged 13 commits intoJan 29, 2024
Merged
Conversation
Author
|
I would like to port the midstream scripts to release-v1.12 and main as well. But will do it manually. |
Author
|
I will need to polish the backports. The tests are stricter now and the APIServerSource test is failing. |
mgencur
changed the title
Author
|
Created #511 for release-v1.12 branch. |
Author
|
/test 411-test-e2e-aws-ocp-411 |
Signed-off-by: Calum Murray <cmurray@redhat.com>
* Fix the merge conflict and fix the logical error in the test Signed-off-by: Leo Li <leoli@redhat.com> * Add the auto eventType creation support Signed-off-by: Leo Li <leoli@redhat.com> * reformat and remove the comments Signed-off-by: Leo Li <leoli@redhat.com> * Remove the assertReference function Signed-off-by: Leo Li <leoli@redhat.com> * fix reviewDog issue Signed-off-by: Leo Li <leoli@redhat.com> * Update test/rekt/resources/eventtype/eventtype.go Co-authored-by: Calum Murray <cmurray@redhat.com> * fix reviewDog issue Signed-off-by: Leo Li <leoli@redhat.com> * Move the test to experimental rekt Signed-off-by: Leo Li <leoli@redhat.com> * Remove the eventtype test from the pingsource rekt test Signed-off-by: Leo Li <leoli@redhat.com> * Rename the test name to make it more intuitive Signed-off-by: Leo Li <leoli@redhat.com> * Revert the unit test change Signed-off-by: Leo Li <leoli@redhat.com> * Format fix Signed-off-by: Leo Li <leoli@redhat.com> * format fix Signed-off-by: Leo Li <leoli@redhat.com> * Fix Christoph's comment Signed-off-by: Leo Li <leoli@redhat.com> * go imports Signed-off-by: Leo Li <leoli@redhat.com> * Update test/experimental/features/eventtype_autocreation/eventtype.go Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Update test/experimental/eventtype_autocreation_test.go Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Apply suggestions from code review Co-authored-by: Christoph Stäbler <cstabler@redhat.com> * Change the name of the file Signed-off-by: Leo Li <leoli@redhat.com> * Update the deprecated string Signed-off-by: Leo Li <leoli@redhat.com> * Update test/rekt/features/pingsource/features.go Co-authored-by: Calum Murray <cmurray@redhat.com> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <leoli@redhat.com> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <leoli@redhat.com> --------- Signed-off-by: Leo Li <leoli@redhat.com> Co-authored-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
* change the deprecated string * Apply suggestions from code review Co-authored-by: Calum Murray <cmurray@redhat.com> --------- Co-authored-by: Calum Murray <cmurray@redhat.com>
…7586) fix: eventtype autocreate for broker asserts that only one et is created Signed-off-by: Calum Murray <cmurray@redhat.com>
Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker.
This reverts commit 7659227.
This reverts commit c8d12c3.
…native#7586)" This reverts commit 4eac230.
This reverts commit e469414.
mgencur
force-pushed
the
backport_eventtype_tests_v1.11
branch
from
4079861 to
51c9082
Compare
Author
|
/test 411-test-e2e-aws-ocp-411 |
Author
|
/test 411-test-reconciler-aws-ocp-411 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport following changes from upstream.
Introduce midstream scripts for executing experimental reconciler tests. They're currently not executed in CI but will be re-used for downstream testing. In the future, they can be enabled in midstream if required.