Skip to content

EventType tests verify the type under spec.reference #7888

Merged
knative-prow[bot] merged 5 commits into
knative:mainfrom
ctmphuongg:event_type_test
May 6, 2024
Merged

EventType tests verify the type under spec.reference #7888
knative-prow[bot] merged 5 commits into
knative:mainfrom
ctmphuongg:event_type_test

Conversation

@ctmphuongg
Copy link
Copy Markdown
Contributor

@ctmphuongg ctmphuongg commented May 3, 2024

Fixes #7629

Proposed Changes

Add check for EventType Reference in tests

@knative-prow knative-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2024
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 3, 2024

Hi @ctmphuongg. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow Bot added the area/test-and-release Test infrastructure, tests or release label May 3, 2024
@knative-prow knative-prow Bot requested review from evankanderson and mgencur May 3, 2024 00:30
@ctmphuongg
Copy link
Copy Markdown
Contributor Author

ctmphuongg commented May 3, 2024

/cc @Cali0707

@knative-prow knative-prow Bot requested a review from Cali0707 May 3, 2024 00:31
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.18%. Comparing base (7e1c082) to head (acff4e8).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7888      +/-   ##
==========================================
- Coverage   69.22%   69.18%   -0.04%     
==========================================
  Files         339      341       +2     
  Lines       19494    15816    -3678     
==========================================
- Hits        13494    10943    -2551     
+ Misses       5337     4200    -1137     
- Partials      663      673      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cali0707
Cali0707 reviewed May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ctmphuongg this looks good to me, just one small request: can you run goimports on the files you changed to fix the formatting error?

@ctmphuongg
Copy link
Copy Markdown
Contributor Author

ctmphuongg commented May 3, 2024

@Cali0707 I just fixed the format.

@Cali0707
Copy link
Copy Markdown
Member

Cali0707 commented May 3, 2024

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2024
Cali0707
Cali0707 reviewed May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change (that should fix the tests) and then this should be good to go @ctmphuongg ! Thanks for working on this!

Comment thread test/rekt/features/apiserversource/data_plane.go Outdated
ctmphuongg and others added 2 commits May 6, 2024 13:57
@ctmphuongg @Cali0707
Update test/rekt/features/apiserversource/data_plane.go
0a21138 
Co-authored-by: Calum Murray <cmurray@redhat.com>
@ctmphuongg
fix syntax
acff4e8
Cali0707
Cali0707 approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @ctmphuongg !

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ctmphuongg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@knative-prow knative-prow Bot merged commit c3a1c19 into knative:main May 6, 2024
@mgencur mgencur mentioned this pull request May 7, 2024
Merged
5 tasks
mgencur pushed a commit to mgencur/eventing that referenced this pull request Aug 20, 2024
@ctmphuongg @Cali0707 @mgencur
EventType tests verify the type under spec.reference (knative#7888)
00d4027 
* test ref

* test for reference

* format

* Update test/rekt/features/apiserversource/data_plane.go

Co-authored-by: Calum Murray <cmurray@redhat.com>

* fix syntax

---------

Co-authored-by: Calum Murray <cmurray@redhat.com>
openshift-merge-bot Bot pushed a commit to openshift-knative/eventing that referenced this pull request Aug 27, 2024
@mgencur @ctmphuongg @Cali0707
EventType tests verify the type under spec.reference (knative#7888) (#…
2f467a6 
…775)

* test ref

* test for reference

* format

* Update test/rekt/features/apiserversource/data_plane.go



* fix syntax

---------

Co-authored-by: Phuong Cao <88098962+ctmphuongg@users.noreply.github.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EventType tests should verify the type under spec.reference

2 participants

@ctmphuongg @Cali0707