Skip to content

Adding corev1.Events to GCP PubSub channel for easier debugging#795

Merged
knative-prow-robot merged 5 commits into
knative:masterfrom
nachocano:gcppubsub-events
Feb 11, 2019
Merged

Adding corev1.Events to GCP PubSub channel for easier debugging#795
knative-prow-robot merged 5 commits into
knative:masterfrom
nachocano:gcppubsub-events

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Feb 8, 2019

Contributes to fix #724

Proposed Changes

  • Adding corev1.Events to GCP PubSub channel in order to make debugging easier.
  • Adding verbs to create/update/patch events to the gcppubsub default configuration
  • Here is the list of the events emitted:

Channel Controller

Name Type Description
ChannelReadStatusFailed Warning When there was an error trying to get the internal status of the channel. Includes the go error string.
SubscriptionSyncFailed Warning When the Channel's subscription couldn't be synced. Includes the go error string.
SubscriptionDeleteFailed Warning When the old Channel's subscriptions couldn't be deleted. Includes the go error string.
GcpCredentialsReadFailed Warning When the GCP credentials couldn't be generated. Includes the go error string.
GcpResourcesPlanFailed Warning When there was an error creating a plan of reconciliation for the GCP resources. Includes the go error string.
GcpResourcesPersistFailed Warning When there was an error trying to persist the planned resources. Includes the go error string.
TopicCreateFailed Warning When there was an error reconciling the topic for the channel. Includes the go error string.
TopicDeleteFailed Warning When there was an error deleting the old topic for the channel. Includes the go error string.
K8sServiceCreateFailed Warning When the K8s Service couldn't be created. Includes the go error string.
VirtualServiceCreateFailed Warning When the Virtual Service couldn't be created. Includes the go error string.
ChannelUpdateStatusFailed Warning When the Channel's status couldn't be updated. It can happen even if the reconciliation process was successful. Includes the go error string.
ChannelReconciled Normal When the Channel's reconciliation process succeeds. This is the "Success" event. Includes the channel name.

ClusterChannelProvisioner Controller

Name Type Description
CcpReconcileFailed Warning When there was a problem reconciling the CCP. Includes the go error string.
CcpUpdateStatusFailed Warning When the CCP's status couldn't be updated. It can happen even if the reconciliation process was successful. Includes the go error string.
CcpReconciled Normal When the CCP's reconciliation process succeeds. This is the "Success" event. Includes the CCP name.

Dispatcher Controller

Name Type Description
DispatcherReconcileFailed Warning When there was a problem reconciling the dispatcher. Includes the go error string.
DispatcherUpdateStatusFailed Warning When the channel's dispatcher status couldn't be updated. It can happen even if the reconciliation process was successful. Includes the go error string.
DispatcherReconciled Normal When the dispatcher reconciliation process succeeds. This is the "Success" event. Includes the channel name.

Release Note

GCP PubSub channel has detailed information when errors occur.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 8, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/cc @Harwayne

Comment thread contrib/gcppubsub/pkg/dispatcher/dispatcher/reconcile.go
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/gcppubsub/pkg/controller/channel/reconcile.go 97.3% 96.5% -0.8
contrib/gcppubsub/pkg/controller/clusterchannelprovisioner/reconcile.go 96.9% 94.4% -2.4

Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2019
@knative-prow-robot knative-prow-robot merged commit 189431d into knative:master Feb 11, 2019
matzew added a commit to matzew/eventing that referenced this pull request Aug 31, 2020
SRVKE-514: Adding upstream backports we want in 0.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emit corev1 Events for debugging purposes

6 participants