Skip to content

Adding verbs to emit corev1.Events to gcp-pubsub dispatcher.#801

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
nachocano:dispatcher-events
Feb 12, 2019
Merged

Adding verbs to emit corev1.Events to gcp-pubsub dispatcher.#801
knative-prow-robot merged 1 commit into
knative:masterfrom
nachocano:dispatcher-events

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Proposed Changes

  • Adding create/update/patch verbs to emit v1 events.
  • This was a bug introduced with a previous PR

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 12, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/cc @Harwayne

@nachocano
Copy link
Copy Markdown
Contributor Author

/cc @grantr

Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@knative-prow-robot knative-prow-robot merged commit ed5d38e into knative:master Feb 12, 2019
matzew added a commit to matzew/eventing that referenced this pull request Sep 1, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants