fix: rename job-sink to job_sink

[yatesliang]

Fixes #8296

Proposed Changes

Rename the JobSink component from 'job-sink' to job_sink to make the generated metrics meet the
Prometheus naming requirement.

ref: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

• 🐛 Fix bug

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

JobSink: all related metrics will start with prefix `job_sink` instead of `job-sink`

Docs

[linux-foundation-easycla]

• ✅login: yatesliang / (2a6c506)

The committers listed above are authorized under a signed CLA.

[knative-prow]

Welcome @yatesliang! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @yatesliang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/ok-to-test

[pierDipi]

Thanks @yatesliang

/lgtm
/approve

/cc @mgencur

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, yatesliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

/kind bug

[pierDipi]

/cherry-pick release-1.15

[pierDipi]

/cherry-pick release-1.16

[knative-prow-robot]

@pierDipi: new pull request created: #8339

Details

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@pierDipi: new pull request created: #8340

Details

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.