Skip to content

[release-v1.16] rename job-sink to job_sink (#8335)#1320

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.16from
matzew:backport_8335_ocp_1.16
Apr 28, 2025
Merged

[release-v1.16] rename job-sink to job_sink (#8335)#1320
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.16from
matzew:backport_8335_ocp_1.16

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Apr 25, 2025

backport to 1.16

@openshift-ci openshift-ci Bot requested review from lberk and pierDipi April 25, 2025 14:03
Copy link
Copy Markdown
Collaborator

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Apr 28, 2025

/test kn-eventing-controller-116-on-pull-request

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.16-417-images
pull-ci-openshift-knative-eventing-release-v1.16-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.16-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler
Details

In response to this:

/test kn-eventing-controller-116-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit d371178 into openshift-knative:release-v1.16 Apr 28, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants