Deprecate calling kubetest2 via kntest by upodroid · Pull Request #230 · knative/hack

upodroid · 2022-09-26T16:05:29Z

Changes

deprecate calling kubetest2 via kntest. It will take a while for the change to propagate.
test PR with the change: Deprecate calling kubetest2 via kntest serving#13329

Fixes #

/cc @cardil

knative-prow · 2022-09-26T16:05:31Z

@upodroid: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

deprecate calling kubetest2 via kntest. It will take a while for the change to propagate. The repos need to be updated + new env variable added to Prow Jobs

test PR with the change: Deprecate calling kubetest2 via kntest serving#13329

/kind

Fixes #

/cc @cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

infra-library.sh

cardil · 2022-09-27T10:30:31Z

Unit tests needs to be updated. They are failing now because they were expecting a call to kntest.

Hit me directly, if you need a help with updating them...

krsna-m · 2023-05-30T20:18:30Z

/lgtm
/hold til announcement time passes

upodroid · 2023-08-15T08:58:56Z

/retest-required

dprotaso · 2023-08-17T22:23:38Z

/hold cancel

dprotaso · 2023-08-17T22:28:43Z

/hold

I see some test is commented out

e2e-tests.sh

infra-library.sh

performance-tests.sh

test/unit/presubmit_test.go

dprotaso · 2023-08-18T12:21:08Z

We can drop that test/assertion if it’s not outputting that anymore

…

On Fri, Aug 18, 2023 at 05:57 knative-prow[bot] ***@***.***> wrote: New changes are detected. LGTM label has been removed. — Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAERASSPOO5L6HFPCRGUIDXV44BXANCNFSM6AAAAAAQV6ISXY> . You are receiving this because you commented.Message ID: ***@***.***>

dprotaso

/lgtm
/approve
/hold

holding for nit - drop if you don't want to do it in this PR

dprotaso · 2023-08-18T15:01:33Z

e2e-tests.sh

 function initialize() {
  local run_tests=0
  local custom_flags=()
+  local extra_gcloud_flags=()


nit: remove this var

I'll revisit this in a separate PR

knative-prow · 2023-08-18T15:02:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dprotaso,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso · 2023-08-18T15:40:47Z

/hold cancel
/lgtm

knative-prow bot requested a review from cardil September 26, 2022 16:05

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2022

cardil reviewed Sep 27, 2022

View reviewed changes

infra-library.sh Outdated Show resolved Hide resolved

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022

deprecate calling kubetest2 via kntest

babaa5c

upodroid force-pushed the deprecate-kntest branch from 0a6289d to babaa5c Compare May 9, 2023 20:06

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023

upodroid mentioned this pull request May 9, 2023

Add env to knative/hack unit tests knative/test-infra#3824

Merged

fix e2e test parameters

171421e

upodroid force-pushed the deprecate-kntest branch from 1b6497b to 171421e Compare May 9, 2023 21:05

upodroid added 2 commits May 10, 2023 00:15

accept some shellcheck suggestions and fix golang typo

770ee49

fix performance tests script too

467bbfe

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023

knative-prow bot assigned krsna-m May 30, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023

dprotaso reviewed Aug 17, 2023

View reviewed changes

e2e-tests.sh Outdated Show resolved Hide resolved

infra-library.sh Outdated Show resolved Hide resolved

performance-tests.sh Show resolved Hide resolved

test/unit/presubmit_test.go Outdated Show resolved Hide resolved

move addons to infra library and put flags on a separate line

68b86d8

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023

cleanup unused test

f4f0ad4

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2023

dprotaso approved these changes Aug 18, 2023

View reviewed changes

knative-prow bot assigned dprotaso Aug 18, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023

upodroid force-pushed the deprecate-kntest branch from 41b408d to f4f0ad4 Compare August 18, 2023 15:38

knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 18, 2023

knative-prow bot merged commit 9cc05a3 into knative:main Aug 18, 2023

upodroid mentioned this pull request Aug 18, 2023

Deprecate calling kubetest2 via kntest knative/eventing#7191

Closed

5 tasks

upodroid mentioned this pull request Aug 28, 2023

Deprecate calling kubetest2 via kntest knative-extensions/eventing-kafka-broker#3311

Merged

upodroid mentioned this pull request Dec 5, 2023

export all deployer struct kubernetes-sigs/kubetest2#252

Closed

Conversation

upodroid commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

knative-prow bot commented Sep 26, 2022

Changes

Uh oh!

Uh oh!

cardil commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krsna-m commented May 30, 2023

Uh oh!

upodroid commented Aug 15, 2023

Uh oh!

dprotaso commented Aug 17, 2023

Uh oh!

dprotaso commented Aug 17, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dprotaso commented Aug 18, 2023 via email

Uh oh!

dprotaso left a comment

Choose a reason for hiding this comment

Uh oh!

dprotaso Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

upodroid Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Aug 18, 2023

Uh oh!

dprotaso commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

upodroid commented Sep 26, 2022 •

edited

Loading

cardil commented Sep 27, 2022 •

edited

Loading