Deprecate calling kubetest2 via kntest

[upodroid]

Testing this change before updating knative/hack

[upodroid]

/test upgrade-tests

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (b3b793f) 86.23% compared to head (83b2195) 86.25%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13329      +/-   ##
==========================================
+ Coverage   86.23%   86.25%   +0.01%     
==========================================
  Files         199      199              
  Lines       14811    14811              
==========================================
+ Hits        12773    12775       +2     
+ Misses       1735     1733       -2     
  Partials      303      303              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[upodroid]

@cardil What do you think?

This change allows us to go from kntest kubetest2 gke to kubetest2 gke with the following benefits:

• direct use of the upstream library, a stale copy of kubetest2 is in our repo which is deprecated and hasn't been updated in a very long time.
• when kntest was kubetest2
• Removes a lot of code from knative/test-infra as we effectively have a kubetest2 + tests
  • https://github.com/knative/test-infra/tree/main/tools/kntest/pkg/kubetest2
  • https://github.com/knative/test-infra/tree/main/pkg/clustermanager/kubetest2
  • https://github.com/knative/test-infra/tree/main/pkg/clustermanager/e2e-tests

If this looks good, I'll make the changes in knative/hack. This needs to be feature gated for a few releases

[nader-ziada]

you need to run ./hack/update-codegen.sh. for the verify failure

[upodroid]

I know, I will update this upstream. I wanted to test the change before submitting it upstream as it is very annoying to iterate.

[upodroid]

/close

I'll pick this up once the signing work is complete.

[knative-prow]

@upodroid: Closed this PR.

Details

In response to this:

/close

I'll pick this up once the signing work is complete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[upodroid]

I need to actually complete this in May to complete the repo migration. One of the blockers is deprecating kntest

[upodroid]

@dprotaso @evankanderson @cardil @kvmware

Are we happy with this change? I'm going to apply it upstream but every repo will need to make small adjustments similar to the changes I made here to the test/*.sh files. This change works and all the e2e tests are passing. Jobs can pass most kubetest2 args and gcloud args from their specific e2e_tests script.

Tl;dr, we need to deprecate kntest and call kubetest2 directly.

[krsna-m]

I don't have an opinion. Just glad we can move on from kntest.
For the test/*.sh changes it would be good to sed replace those and open at same time, or at the very least make sure that is only things that need changing. Would suck to find some repo's test scripts that require a lot of work to get going and are unable to test.

[dprotaso]

no issues from me

[upodroid]

I rebased this PR.

[dprotaso]

/retest

[upodroid]

I'm going to override the lint checks

[upodroid]

/override "style / suggester / shell"

[knative-prow]

@upodroid: Overrode contexts on behalf of upodroid: style / suggester / shell

Details

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[krsna-m]

/lgtm

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment