Skip to content

[WIP] Reproduce the failure of getting the description in a vendorless project #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cardil wants to merge 1 commit into from
Closed

[WIP] Reproduce the failure of getting the description in a vendorless project #417

cardil wants to merge 1 commit into from

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Mar 14, 2025

Changes

  • 🐛 Reproduce the failure of getting the description in a vendorless project

/kind bug

Fixes #416

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Mar 14, 2025
@knative-prow knative-prow bot requested a review from evankanderson March 14, 2025 10:19
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from mgencur March 14, 2025 10:19
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2025
cardil
cardil commented Mar 14, 2025
View reviewed changes
schema/docs/docs.go
// vendor mode
pkgDir = vendoredPkg
} else {
pkgDir = path.Join(gomodcache(), pkgDir)
Copy link
Contributor Author

@cardil cardil Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct.

We need to join: GOMODCACHE, dep.name+@dep.version, rest-of-the-package (see similar code)

To do it we need the current gomod file

Copy link
Contributor Author

@cardil cardil Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/test unit

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

@cardil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-tests

/test integration-tests

/test kind-tests

/test unit-tests

Use /test all to run all jobs.

Details

In response to this:

/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/test unit-tests

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

@cardil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_hack_main 8b70e5a link true /test unit-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

#416 reproduced in https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_hack/417/unit-tests_hack_main/1900493473102958592

@cardil cardil mentioned this pull request Mar 14, 2025
Closed
@cardil
Copy link
Contributor Author

cardil commented Mar 18, 2025

/close

By #418

@knative-prow knative-prow bot closed this Mar 18, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 18, 2025

@cardil: Closed this PR.

Details

In response to this:

/close

By #418

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil cardil deleted the bugfix/schemagen-desc-vendorless branch March 18, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema tool produce invalid docs in vendorless projects

1 participant

@cardil