-
Notifications
You must be signed in to change notification settings - Fork 69
[WIP] Reproduce the failure of getting the description in a vendorless project #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module knative.dev/hack | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| go 1.21 | ||
| go 1.22.7 | ||
|
|
||
| use ( | ||
| . | ||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package docs | ||
|
|
||
| import ( | ||
| "go/build" | ||
| "os" | ||
| "path/filepath" | ||
| ) | ||
|
|
||
| func gomodcache() string { | ||
| // See: https://github.com/golang/go/blob/release-branch.go1.22/src/cmd/go/internal/cfg/cfg.go#L408 | ||
| return envOr("GOMODCACHE", gopathDir("pkg/mod")) | ||
| } | ||
|
|
||
| func gopathDir(rel string) string { | ||
| list := filepath.SplitList(gopath()) | ||
| if len(list) == 0 || list[0] == "" { | ||
| return "" | ||
| } | ||
| return filepath.Join(list[0], rel) | ||
| } | ||
|
|
||
| func gopath() string { | ||
| gp := os.Getenv("GOPATH") | ||
| if gp == "" { | ||
| gp = build.Default.GOPATH | ||
| } | ||
| return gp | ||
| } | ||
|
|
||
| func envOr(key string, def string) string { | ||
| val := os.Getenv(key) | ||
| if val == "" { | ||
| val = def | ||
| } | ||
| return val | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,41 @@ | ||
| module knative.dev/hack/schema | ||
|
|
||
| go 1.21 | ||
| go 1.22.7 | ||
|
|
||
| require ( | ||
| github.com/spf13/cobra v1.5.0 | ||
| gopkg.in/yaml.v3 v3.0.1 | ||
| k8s.io/apimachinery v0.29.2 | ||
| k8s.io/apimachinery v0.30.3 | ||
| knative.dev/pkg v0.0.0-20241128013618-f3ab5605e542 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/go-logr/logr v1.3.0 // indirect | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/evanphx/json-patch/v5 v5.9.0 // indirect | ||
| github.com/go-logr/logr v1.4.2 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| github.com/google/gofuzz v1.2.0 // indirect | ||
| github.com/inconshreveable/mousetrap v1.0.0 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/kr/text v0.2.0 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.2 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/spf13/pflag v1.0.5 // indirect | ||
| golang.org/x/net v0.25.0 // indirect | ||
| golang.org/x/text v0.15.0 // indirect | ||
| gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect | ||
| golang.org/x/net v0.31.0 // indirect | ||
| golang.org/x/oauth2 v0.23.0 // indirect | ||
| golang.org/x/sys v0.27.0 // indirect | ||
| golang.org/x/term v0.26.0 // indirect | ||
| golang.org/x/text v0.20.0 // indirect | ||
| golang.org/x/time v0.6.0 // indirect | ||
| gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| k8s.io/klog/v2 v2.110.1 // indirect | ||
| k8s.io/utils v0.0.0-20230726121419-3b25d923346b // indirect | ||
| k8s.io/api v0.30.3 // indirect | ||
| k8s.io/client-go v0.30.3 // indirect | ||
| k8s.io/klog/v2 v2.130.1 // indirect | ||
| k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 // indirect | ||
| sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | ||
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module knative.dev/hack/test | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| require ( | ||
| github.com/abiosoft/lineprefix v0.1.4 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module knative.dev/hack/test/vendorproj | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| require github.com/stretchr/testify v1.8.4 | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct.
We need to join:
GOMODCACHE, dep.name+@dep.version, rest-of-the-package (see similar code)To do it we need the current gomod file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold