Add activator-ca and activator-name keys in config-network#608
Conversation
This pach adds `activator-ca` and `activator-name` keys in `config-network`. Part of knative-extensions/net-kourier#750 knative-extensions/net-kourier#761 demonstrates how it works.
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 94.76% 94.78% +0.02%
==========================================
Files 38 38
Lines 802 806 +4
==========================================
+ Hits 760 764 +4
Misses 30 30
Partials 12 12
Continue to review full report at Codecov.
|
|
Although I added the name with |
|
Could you please take a look? |
| # | ||
| # NOTE: This flag is in an alpha state and is mostly here to enable internal testing | ||
| # for now. Use with caution. | ||
| activator-name: "" |
There was a problem hiding this comment.
nit: I slightly prefer activator-san to activator-name as activator-name seems too generic. But if you folks have already decided to use activator-name, it is OK to me.
There was a problem hiding this comment.
Yeah, users may misunderstand as activator-name means activator's deployment name or something.
Updated the configuration as activator-san. Thank you.
* Add certificates keys in config-network This patch adds the following certificate variables: - `activator-server-certs` - `queue-proxy-ca` - `queue-proxy-san` - `queue-proxy-server-certs` It is similar to #608. knative/serving#12815 and knative/serving#12770 verifeid the change. * Rename -server-certs with -cert-secret * Bump checksum * Fix lint
3 participants
This pach adds
activator-caandactivator-namekeys inconfig-network.Part of knative-extensions/net-kourier#750
knative-extensions/net-kourier#761 demonstrates how it works.
/cc @evankanderson @julz @carlisia