Skip to content

Add validation for activator-ca and activator-san#637

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
nak3:add-validation
Mar 18, 2022
Merged

Add validation for activator-ca and activator-san#637
knative-prow-robot merged 1 commit into
knative:mainfrom
nak3:add-validation

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Mar 18, 2022

This is a follow up for #608.

This patch adds a validation to disallow activator-ca without activator-san.
I think we can relax the validation in the future if users want to skip SAN validation
but the initial implementation should be strict.

/cc @evankanderson @ZhiminXiang @carlisia

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2022

Codecov Report

Merging #637 (1f27f8a) into main (f35c7e7) will decrease coverage by 0.22%.
The diff coverage is 50.00%.

❗ Current head 1f27f8a differs from pull request most recent head 8e37be9. Consider uploading reports for the commit 8e37be9 to get more accurate results

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   94.78%   94.56%   -0.23%     
==========================================
  Files          38       38              
  Lines         806      810       +4     
==========================================
+ Hits          764      766       +2     
- Misses         30       31       +1     
- Partials       12       13       +1     
Impacted Files Coverage Δ
pkg/network.go 85.91% <50.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35c7e7...8e37be9. Read the comment docs.

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@knative-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ec52d71 into knative:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants