Skip to content

Set E2E_UPGRADE_TESTS_SERVING_USE to test kservice in eventing tests#274

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
cardil:feature/eventing-upgrade-test-iteroop
Sep 16, 2020
Merged

Set E2E_UPGRADE_TESTS_SERVING_USE to test kservice in eventing tests#274
knative-prow-robot merged 1 commit into
knative:masterfrom
cardil:feature/eventing-upgrade-test-iteroop

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented Sep 11, 2020

Fixes #252

Proposed Changes

  • Upgrade tests for Eventing utilize Knative Serving forwarder component while running in Operator tests

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2020
@cardil cardil force-pushed the feature/eventing-upgrade-test-iteroop branch from ff3468a to 502bfbd Compare September 11, 2020 17:00
@matzew
Copy link
Copy Markdown
Member

matzew commented Sep 14, 2020

looks like the upgrade fails?

@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Sep 14, 2020

Re: @matzew

looks like the upgrade fails?

Yeah. But, it's strange as it isn't something that I've changed.

@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Sep 14, 2020

/test pull-knative-operator-upgrade-tests

@cardil cardil force-pushed the feature/eventing-upgrade-test-iteroop branch 2 times, most recently from c8abb18 to 7891614 Compare September 14, 2020 14:37
@cardil cardil force-pushed the feature/eventing-upgrade-test-iteroop branch from 7891614 to 91e37a2 Compare September 14, 2020 15:27
@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Sep 14, 2020

Okay. That was my fault. Now it is working correctly. But the serving component didn't appear in the logs.

That's due to knative/eventing#3899 not being in release-0.17 branch. To do it we either need to backport it to release-0.17 branch or wait with this PR until release-0.18 branch is cut.

houshengbo
houshengbo reviewed Sep 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 16, 2020
@knative-prow-robot knative-prow-robot merged commit f9377ee into knative:master Sep 16, 2020
@cardil cardil deleted the feature/eventing-upgrade-test-iteroop branch February 12, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houshengbo houshengbo houshengbo left review comments

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

Assignees

@houshengbo houshengbo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade tests for Eventing should utilize Knative Serving forwarder component

5 participants

@cardil @matzew @knative-prow-robot @houshengbo @googlebot