Flags to configure eventing upgrade tests forwarder (ksvc)#3899
Conversation
knative-prow-robot
added
the
size/M
knative-prow-robot
added
the
area/test-and-release
This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables.
cardil
force-pushed
the
bugfix/configurable-wathola-forwarder
branch
from
77551f6 to
2c2ec1e
Compare
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
cardil
force-pushed
the
bugfix/configurable-wathola-forwarder
branch
from
17c42bc to
c3b643b
Compare
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
cardil
force-pushed
the
bugfix/configurable-wathola-forwarder
branch
from
c3b643b to
bbc054f
Compare
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
cardil
force-pushed
the
bugfix/configurable-wathola-forwarder
branch
from
bbc054f to
4f4b5a3
Compare
|
@vaikas does this look good to you now? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
) * Flags to configure eventing upgrade tests forwarder (ksvc) This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables. * Using kelseyhightower/envconfig after code review * Docs for Eventing upgrade tests config overrides.
* Flags to configure eventing upgrade tests forwarder (ksvc) (knative#3899) * Flags to configure eventing upgrade tests forwarder (ksvc) This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables. * Using kelseyhightower/envconfig after code review * Docs for Eventing upgrade tests config overrides. * Eventing upgrade tests prober fully configurable Conflicts resolved: * test/upgrade/prober/configuration.go * test/upgrade/prober/forwarder.go
5 participants
This change is required to complete knative/operator#252
It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables.
Proposed Changes