Skip to content

Upgrade tests prober shouldn't have static constants that can't be overridden at vendor level #4420

@cardil

Description

@cardil

Describe the bug
Currently, we are experiencing problem with integrating Eventing upgrade tests in our product (see: openshift-knative/serverless-operator#530 (comment)). That is caused by the fact, that we are using a different base image for test images. That also changes the path in which wathola config is search for. The ConfigMap mount point is now a constant (see: https://github.com/knative/eventing/blob/2a052db/test/upgrade/prober/configuration.go#L38), so we have no way to change that in configuration options. Part of those configuration options are already dynamic thanks to PR #3899.

Expected behavior
Eventing upgrade test prober options should be configurable from outside the code. More constants should be moved to be dynamically configured. Preferably by kelseyhightower/envconfig

To Reproduce
openshift-knative/serverless-operator#530

Knative release version
>= 0.17

Additional context
This issue is urgent for our team, and we'd like to make it fixed as soon as possible.

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions