Eventing upgrade tests#530
Merged
openshift-merge-robot merged 21 commits intoNov 2, 2020
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Member
Author
|
/test all |
cardil
force-pushed
the
feature/SRVKE-475-eventing-upgrade-tests
branch
from
8914d4c to
5047f4c
Compare
Member
Author
|
/retest |
mgencur
reviewed
Oct 9, 2020
Contributor
mgencur
left a comment
mgencur
left a comment
There was a problem hiding this comment.
Overall, looks good! Just a few minor things.
I'd also like to see the tests in action. AFAIK, this PR now runs only the Serving upgrade tests, right?
Member
Author
|
/test all |
cardil
commented
Oct 9, 2020
Member
Author
|
/test all |
Contributor
|
@cardil The PR looks good to me but the upgrade tests have a failure in the logs: But they still report success. |
Member
Author
|
Yeah. I know. The error reporting is still not working well for some reason. |
…-eventing-upgrade-tests Conflicts fixed: * hack/lib/serverless.bash * test/upstream-e2e-tests.sh
…-eventing-upgrade-tests Conflicts fixed: * hack/lib/catalogsource.bash * hack/lib/vars.bash * test/upstream-e2e-tests.sh
…-eventing-upgrade-tests
Contributor
|
/retest |
mgencur
reviewed
Oct 26, 2020
…-eventing-upgrade-tests Conflicts fixes: * hack/lib/serverless.bash * test/serving.bash * test/upstream-e2e-tests.sh
…-eventing-upgrade-tests Conflicts resolved: * hack/lib/catalogsource.bash * test/lib.bash
Member
Author
|
/test all |
This was referenced Oct 28, 2020
This was referenced Oct 30, 2020
Member
Author
|
/test all |
Member
Author
|
/retest |
cardil
commented
Nov 1, 2020
To avoid loosing events and most notably "finished" event, I'm lowering interval between sent event to 50 ms from previously used 2 ms.
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cardil
added a commit
to cardil/serverless-operator
that referenced
this pull request
Nov 2, 2020
Eventing upgrade tests * Splitting upgrade test to accommodate Eventing * Add an image template * Upgrade tests with Eventing by default * Proper error reporting from shell scripts * Remove serving & eventing ns at teardown * Adding missing return statements + prober end idempotency * Declare a waited PIDs array * Rely on PID directory instead of Bash arrays * Eventing test bits deploy properly * Proper waiting on prober's end * Creating a namespaces for previous release * Add env vars to configure upgrade tests * Lowering interval from 2ms to 50ms To avoid loosing events and most notably "finished" event, I'm lowering interval between sent event to 50 ms from previously used 2 ms.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Nov 2, 2020
Eventing upgrade tests * Splitting upgrade test to accommodate Eventing * Add an image template * Upgrade tests with Eventing by default * Proper error reporting from shell scripts * Remove serving & eventing ns at teardown * Adding missing return statements + prober end idempotency * Declare a waited PIDs array * Rely on PID directory instead of Bash arrays * Eventing test bits deploy properly * Proper waiting on prober's end * Creating a namespaces for previous release * Add env vars to configure upgrade tests * Lowering interval from 2ms to 50ms To avoid loosing events and most notably "finished" event, I'm lowering interval between sent event to 50 ms from previously used 2 ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing an Eventing upgrade tests to be executed withing a CI.