Skip to content

[1.11] Backport of Eventing upgrade tests#659

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:release-1.11from
cardil:backport/pr-530
Nov 2, 2020
Merged

[1.11] Backport of Eventing upgrade tests#659
openshift-merge-robot merged 1 commit into
openshift-knative:release-1.11from
cardil:backport/pr-530

Conversation

@cardil
Copy link
Copy Markdown
Member

@cardil cardil commented Nov 2, 2020

Backport of Eventing upgrade tests (#530)

  • Splitting upgrade test to accommodate Eventing
  • Add an image template
  • Upgrade tests with Eventing by default
  • Proper error reporting from shell scripts
  • Remove serving & eventing ns at teardown
  • Adding missing return statements + prober end idempotency
  • Declare a waited PIDs array
  • Rely on PID directory instead of Bash arrays
  • Eventing test bits deploy properly
  • Proper waiting on prober's end
  • Creating a namespaces for previous release
  • Add env vars to configure upgrade tests
  • Lowering interval from 2ms to 50ms

To avoid loosing events and most notably "finished" event, I'm lowering
interval between sent event to 50 ms from previously used 2 ms.

Eventing upgrade tests

* Splitting upgrade test to accommodate Eventing
* Add an image template
* Upgrade tests with Eventing by default
* Proper error reporting from shell scripts
* Remove serving & eventing ns at teardown
* Adding missing return statements + prober end idempotency
* Declare a waited PIDs array
* Rely on PID directory instead of Bash arrays
* Eventing test bits deploy properly
* Proper waiting on prober's end
* Creating a namespaces for previous release
* Add env vars to configure upgrade tests
* Lowering interval from 2ms to 50ms

To avoid loosing events and most notably "finished" event, I'm lowering
interval between sent event to 50 ms from previously used 2 ms.
@cardil cardil requested review from matzew and mgencur November 2, 2020 12:29
@cardil cardil changed the title Backport of Eventing upgrade tests (#530) [1.11] Backport of Eventing upgrade tests (#530) Nov 2, 2020
@cardil cardil changed the title [1.11] Backport of Eventing upgrade tests (#530) [1.11] Backport of Eventing upgrade tests Nov 2, 2020
@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Nov 2, 2020

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e6d443c into openshift-knative:release-1.11 Nov 2, 2020
@cardil cardil deleted the backport/pr-530 branch November 2, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants