Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Backport of 4421 review changes#933

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v0.17.2from
cardil:bugfix/4421-review-backport
Oct 29, 2020
Merged

Backport of 4421 review changes#933
openshift-merge-robot merged 1 commit into
openshift:release-v0.17.2from
cardil:bugfix/4421-review-backport

Conversation

@cardil
Copy link
Copy Markdown

@cardil cardil commented Oct 29, 2020

This is required to complete openshift-knative/serverless-operator#530

Conflicts resolved:
 * test/upgrade/prober/configuration.go
@devguyio
Copy link
Copy Markdown

/lgtm
Leaving it up to @lberk or @matzew to approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, devguyio, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5472d92 into openshift:release-v0.17.2 Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants