This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[release-v0.17.2] Hotfix: Deploying receiver as ksvc if serving is available#938
Merged
openshift-merge-robot merged 1 commit intoNov 1, 2020
Conversation
openshift-ci-robot
added
the
area/test-and-release
cardil
changed the title
Member
|
/test all |
Member
|
/lgtm |
Member
|
/lgtm |
openshift-ci-robot
added
lgtm
cardil
force-pushed
the
hotfix/wathola-use-ksvc
branch
from
188c208 to
c95b942
Compare
openshift-ci-robot
removed
lgtm
Author
|
/retest |
Member
|
/test all |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible backport of upstream PR knative#4430. That depends on that upstream PR being merged. I don't give a huge confidence that happening.
If upstream PR will be merged, then nothing more isn't required for 0.18+.
Otherwise, this PR must be also converted to a patch on master branch. Then it must be applied on each release-next, until a proper fix for knative#3175 is provided.
This is required for openshift-knative/serverless-operator#530 (comment)