Skip to content

Implement the second wave of per-reconciler leaderelection#1302

Merged
knative-prow-robot merged 3 commits intoknative:masterfrom
mattmoor:leader-aware-reconcilers
Jun 19, 2020
Merged

Implement the second wave of per-reconciler leaderelection#1302
knative-prow-robot merged 3 commits intoknative:masterfrom
mattmoor:leader-aware-reconcilers

Conversation

@mattmoor
Copy link
Copy Markdown
Member

@mattmoor mattmoor commented May 5, 2020

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 5, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 5, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@mattmoor mattmoor mentioned this pull request May 5, 2020
Merged
@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch 3 times, most recently from 7c94646 to c391044 Compare May 11, 2020 15:00
@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch 3 times, most recently from 42648f5 to 1dd67ce Compare May 14, 2020 20:08
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2020
@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch from 1dd67ce to 6c17b1c Compare May 29, 2020 22:34
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2020
@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch 2 times, most recently from 89c6f22 to 0952388 Compare May 29, 2020 23:56
@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch from 0952388 to 4edf767 Compare June 6, 2020 20:49
@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch from 4edf767 to 4e4c473 Compare June 19, 2020 02:22
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 19, 2020
@mattmoor mattmoor changed the title [WIP] Implement the second wave of per-reconciler leaderelection Implement the second wave of per-reconciler leaderelection Jun 19, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2020
vagababov
vagababov reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most issues I have are repetitive from WH to WH. If they're not issues, probably deserve comments :)

Comment thread webhook/certificates/certificates.go Outdated
Comment thread webhook/configmaps/configmaps.go Outdated
Comment thread webhook/configmaps/configmaps.go Outdated
dprotaso
dprotaso reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some test coverage?

@mattmoor mattmoor force-pushed the leader-aware-reconcilers branch from db884db to c115a62 Compare June 19, 2020 15:54
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 19, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
webhook/certificates/certificates.go 86.2% 83.9% -2.3
webhook/configmaps/configmaps.go 94.2% 91.7% -2.5
webhook/psbinding/psbinding.go 88.1% 87.4% -0.7
webhook/psbinding/reconciler.go 79.6% 78.7% -0.9
webhook/resourcesemantics/conversion/controller.go 100.0% 75.0% -25.0
webhook/resourcesemantics/conversion/reconciler.go 96.4% 90.3% -6.1
webhook/resourcesemantics/defaulting/defaulting.go 88.6% 87.4% -1.2
webhook/resourcesemantics/validation/reconcile_config.go 95.6% 91.7% -3.9

dprotaso
dprotaso approved these changes Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dprotaso dprotaso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

leaving lgtm to vagababov

Comment thread webhook/certificates/controller.go
// Reconcile when the cert bundle changes.
secretInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: controller.FilterWithNameAndNamespace(system.Namespace(), wh.secretName),
FilterFunc: controller.FilterWithNameAndNamespace(key.Namespace, key.Name),
Copy link
Copy Markdown
Member

@dprotaso dprotaso Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol the func name FilterWithNameAndNamespace doesn't match the args order

Copy link
Copy Markdown
Member Author

@mattmoor mattmoor Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and it'd be nice if it took a types.NamespacedName 🙄

vagababov
vagababov reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 19, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit bfc0cee into knative:master Jun 19, 2020
@mattmoor mattmoor deleted the leader-aware-reconcilers branch June 19, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso approved these changes

@n3wscott n3wscott Awaiting requested review from n3wscott

@tcnghia tcnghia Awaiting requested review from tcnghia

@vaikas vaikas Awaiting requested review from vaikas

+1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dprotaso dprotaso

@vagababov vagababov

@vaikas vaikas

@yanweiguo yanweiguo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mattmoor @knative-metrics-robot @vaikas @knative-prow-robot @dprotaso @vagababov @googlebot @yanweiguo