Skip to content

Implement the third wave of per-reconciler leaderelection#1303

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
mattmoor:enable-webhook-leaderelection
Jun 19, 2020
Merged

Implement the third wave of per-reconciler leaderelection#1303
knative-prow-robot merged 1 commit intoknative:masterfrom
mattmoor:enable-webhook-leaderelection

Conversation

@mattmoor
Copy link
Copy Markdown
Member

@mattmoor mattmoor commented May 5, 2020

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 5, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 5, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@mattmoor mattmoor mentioned this pull request May 5, 2020
Merged
@mattmoor
Copy link
Copy Markdown
Member Author

mattmoor commented May 6, 2020

/retest

@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch 3 times, most recently from e7d2d22 to abaee33 Compare May 11, 2020 15:00
@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch 3 times, most recently from d2eb54b to fecb2d3 Compare May 14, 2020 20:08
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2020
@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch from fecb2d3 to b270162 Compare May 29, 2020 22:34
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 29, 2020
@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch 2 times, most recently from b73272f to e9012cd Compare May 29, 2020 23:56
@mattmoor mattmoor mentioned this pull request May 30, 2020
Closed
@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch from e9012cd to 3747ddb Compare June 6, 2020 20:49
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 6, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
controller/controller.go 92.9% 91.3% -1.5
leaderelection/config.go 56.5% 72.0% 15.5
leaderelection/context.go Do not exist 81.8%
reconciler/leader.go Do not exist 100.0%
webhook/certificates/certificates.go 86.2% 83.9% -2.3
webhook/certificates/controller.go 100.0% 87.5% -12.5
webhook/configmaps/configmaps.go 94.3% 91.8% -2.5
webhook/configmaps/controller.go 100.0% 91.7% -8.3
webhook/psbinding/controller.go 100.0% 92.3% -7.7
webhook/psbinding/psbinding.go 88.1% 87.4% -0.7
webhook/psbinding/reconciler.go 79.6% 78.7% -0.9
webhook/resourcesemantics/conversion/controller.go 100.0% 80.0% -20.0
webhook/resourcesemantics/conversion/reconciler.go 96.4% 90.3% -6.1
webhook/resourcesemantics/defaulting/controller.go 100.0% 90.9% -9.1
webhook/resourcesemantics/defaulting/defaulting.go 88.5% 87.3% -1.2
webhook/resourcesemantics/validation/controller.go 100.0% 93.8% -6.2
webhook/resourcesemantics/validation/reconcile_config.go 95.5% 91.5% -4.0

@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch from 3747ddb to f03b724 Compare June 19, 2020 16:52
@knative-prow-robot knative-prow-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 19, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor changed the title [WIP] Implement the third wave of per-reconciler leaderelection Implement the third wave of per-reconciler leaderelection Jun 19, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2020
vagababov
vagababov reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@mattmoor
Implement the third wave of per-reconciler leaderelection.
581159d 
This lets downstream components enable leaderelection on `WebhookMain*`-based components.

Detailed design: https://docs.google.com/document/d/1i_QHjQO2T3SNv49xjZLWlivcc0UvZN1Tbw2NKxThkyM/edit#
Issue: knative#1181
@mattmoor mattmoor force-pushed the enable-webhook-leaderelection branch from f03b724 to 581159d Compare June 19, 2020 18:16
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
vagababov
vagababov reviewed Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@knative-prow-robot knative-prow-robot merged commit b6a13e2 into knative:master Jun 19, 2020
@mattmoor mattmoor deleted the enable-webhook-leaderelection branch June 19, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgerd dgerd Awaiting requested review from dgerd

@dprotaso dprotaso Awaiting requested review from dprotaso

@grantr grantr Awaiting requested review from grantr

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dprotaso dprotaso

@vagababov vagababov

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mattmoor @knative-metrics-robot @knative-prow-robot @vagababov @dprotaso @googlebot @vaikas