Added Audience field in duckv1.Destination

[abhijeetgauravm]

Changes

• Added Audience field in duckv1.Destination

/kind

Fixes #2796

Release Note

Docs

[knative-prow]

@abhijeetgauravm: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #2796

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: abhijeetgauravm / name: Abhijeet Gaurav (440f9fa, f0dcb8e, 53fcf69, e6fa5f3)

[knative-prow]

Welcome @abhijeetgauravm! It looks like this is your first PR to knative/pkg 🎉

[knative-prow]

Hi @abhijeetgauravm. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[creydr]

Hello @abhijeetgauravm,
thanks for your PR. Most of the knative repositories have a hack folder with some scripts (e.g. to update dependencies or to update generated code). You need to run hack/update-codegen.sh to generate/update the DeepCopy functions to include the new field.

[abhijeetgauravm]

Hello @abhijeetgauravm, thanks for your PR. Most of the knative repositories have a hack folder with some scripts (e.g. to update dependencies or to update generated code). You need to run hack/update-codegen.sh to generate/update the DeepCopy functions to include the new field.

@creydr done with the required changes!

[creydr]

/ok-to-test

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (211243a) 81.84% compared to head (e6fa5f3) 81.78%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
- Coverage   81.84%   81.78%   -0.06%     
==========================================
  Files         167      167              
  Lines       10217    10217              
==========================================
- Hits         8362     8356       -6     
- Misses       1610     1614       +4     
- Partials      245      247       +2     

Files Changed	Coverage Δ
apis/duck/v1/destination.go	94.23% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[creydr]

Thanks for your contribution @abhijeetgauravm
/lgtm

/assign @pierDipi

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeetgauravm, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• apis/duck/OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment