Added Audience field in duckv1.Addressable by abhijeetgauravm · Pull Request #2798 · knative/pkg

abhijeetgauravm · 2023-08-17T09:04:49Z

changes

Added Audience field in duckv1.Addressable

/kind

Fixes #2795

Release Note

Docs

knative-prow · 2023-08-17T09:04:50Z

@abhijeetgauravm: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

Added Audience field in duckv1.Addressable

/kind

Fixes #2795

Release Note
Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow · 2023-08-17T09:04:58Z

Hi @abhijeetgauravm. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

creydr · 2023-08-17T09:34:10Z

Hello @abhijeetgauravm,
Thanks for your contribution.
Here applies the same as for #2797 (comment). Can you run hack/update-codegen.sh to generate/update the DeepCopy functions to include the new field?

pierDipi · 2023-08-25T12:27:49Z

@abhijeetgauravm any updates related to the comment above?

abhijeetgauravm · 2023-08-25T13:07:14Z

@abhijeetgauravm any updates related to the comment above?

hey @pierDipi actually should i run update-codegen.sh command on my terminal to generate/update the DeepCopy functions. Actually i am beginner . Could you help a bit?

pierDipi · 2023-08-25T13:40:22Z

@abhijeetgauravm yes, you need to run hack/update-codegen.sh in your terminal and then commit/push the difference

abhijeetgauravm · 2023-08-25T13:50:53Z

hack/update-codegen.sh

but doing this in terminal nothing happens in terminal. Should i push it only running the command like this @pierDipi

creydr · 2023-09-04T12:03:11Z

hack/update-codegen.sh

but doing this in terminal nothing happens in terminal. Should i push it only running the command like this @pierDipi

Hi @abhijeetgauravm,
the hack/update-codegen.sh is a shell/bash script, so you need to run it on some kind of UNIX machine or use something like WSL when you are on Windows. Also you should run it from the repo root dir AFAIK (./hack/update-codegen.sh)

Signed-off-by: Abhijeet Gaurav <abhijeetdav24aug@gmail.com>

abhijeetgauravm · 2023-09-04T16:30:31Z

@creydr done !

creydr · 2023-09-05T05:07:40Z

/ok-to-test

codecov · 2023-09-05T05:33:42Z

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (211243a) 81.84% compared to head (c92d7a5) 81.78%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2798      +/-   ##
==========================================
- Coverage   81.84%   81.78%   -0.06%     
==========================================
  Files         167      167              
  Lines       10217    10217              
==========================================
- Hits         8362     8356       -6     
- Misses       1610     1614       +4     
- Partials      245      247       +2

Files Changed	Coverage Δ
apis/duck/v1/addressable_types.go	`90.90% <ø> (ø)`

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

creydr

Thanks for your contribution @abhijeetgauravm. I left one comment about the code style

Co-authored-by: Christoph Stäbler <cstabler@redhat.com>

creydr

Thanks a lot for you contribution and patience @abhijeetgauravm

/lgtm

creydr · 2023-09-05T13:08:25Z

/assign @pierDipi

pierDipi

/lgtm
/approve

knative-prow · 2023-09-05T14:35:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeetgauravm, creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~apis/duck/OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added Audience field in duckv1.Addressable

f7c6bbd

knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2023

knative-prow Bot requested review from matzew and pierDipi August 17, 2023 09:04

Merge branch 'knative:main' into abhijeetgauravm-duckv1addressable

db82d8f

abhijeetgauravm and others added 2 commits September 4, 2023 16:28

generated the DeepCopy functions to include the new field

dce2c29

Signed-off-by: Abhijeet Gaurav <abhijeetdav24aug@gmail.com>

Merge branch 'knative:main' into abhijeetgauravm-duckv1addressable

6934a45

knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2023

creydr reviewed Sep 5, 2023

View reviewed changes

Comment thread apis/duck/v1/addressable_types.go Outdated

removing one empty line

c92d7a5

Co-authored-by: Christoph Stäbler <cstabler@redhat.com>

creydr approved these changes Sep 5, 2023

View reviewed changes

knative-prow Bot assigned creydr Sep 5, 2023

knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023

knative-prow Bot assigned pierDipi Sep 5, 2023

pierDipi approved these changes Sep 5, 2023

View reviewed changes

knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023

knative-prow Bot merged commit 66bf5af into knative:main Sep 5, 2023

Conversation

abhijeetgauravm commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

changes

Uh oh!

knative-prow Bot commented Aug 17, 2023

Changes

Uh oh!

knative-prow Bot commented Aug 17, 2023

Uh oh!

creydr commented Aug 17, 2023

Uh oh!

pierDipi commented Aug 25, 2023

Uh oh!

abhijeetgauravm commented Aug 25, 2023

Uh oh!

pierDipi commented Aug 25, 2023

Uh oh!

abhijeetgauravm commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

creydr commented Sep 4, 2023

Uh oh!

abhijeetgauravm commented Sep 4, 2023

Uh oh!

creydr commented Sep 5, 2023

Uh oh!

codecov Bot commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

creydr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

creydr left a comment

Choose a reason for hiding this comment

Uh oh!

creydr commented Sep 5, 2023

Uh oh!

pierDipi left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow Bot commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abhijeetgauravm commented Aug 17, 2023 •

edited

Loading

abhijeetgauravm commented Aug 25, 2023 •

edited

Loading

codecov Bot commented Sep 5, 2023 •

edited

Loading