Remove strict name metadata check to be shareable in eventing#44
Merged
Conversation
knative-prow-robot
added
the
size/M
Contributor
Author
|
/assign @mattmoor |
Member
|
/lgtm I'd like to get this check into |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Member
|
poke (for gubernator) |
chengjingtao
pushed a commit
to katanomi/knative-pkg
that referenced
this pull request
Oct 22, 2024
…native#44) - Compares two conditions and returns true if the condition changed
chengjingtao
pushed a commit
to katanomi/knative-pkg
that referenced
this pull request
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventing uses names like "dev.knatave.github.pullrequest" as a event type name. This fails the generic validation added for serving. Moving this logic to serving and removing from pkg.