Adding serving specific name validation to serving.#1854
Conversation
knative-prow-robot
added
the
size/L
|
/assign @mattmoor |
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
hold in case you care to fix the nit.
| "strings" | ||
| ) | ||
|
|
||
| func validateMetadata(new webhook.GenericCRD) *apis.FieldError { |
There was a problem hiding this comment.
This could just take ObjectMeta too
There was a problem hiding this comment.
Good point. Refactored.
knative-prow-robot
added
lgtm
|
/unhold PR is updated with the feedback applied and dep updated from pkg change. |
|
The following is the coverage report on pkg/.
|
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| func validateObjectMetadata(meta metav1.Object) *apis.FieldError { |
There was a problem hiding this comment.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Eventing wants to share the webhook code in pkg, but there was serving limitations on name that did not apply to eventing. Moved that limitation to serving.
relates to knative/pkg#44