Sidecar ports should not conflict with user ports

[dgerd]

Expected Behavior

As a user of Knative I can pick any valid port for my container.

Actual Behavior

Currently ports 8012 and 8022 are hardcoded and used by the QueueProxy sidecar. Since they share the same network interface as the user container, the user container cannot select these ports. Use of these ports are currently blocked by the webhook (#2753). This issue is to update the QueueProxy to allow it to be started on arbitrary ports, and update the routing to the QueueProxy to support the arbitrary port.

Additional Info

https://github.com/knative/serving/blob/master/pkg/queue/constants.go
https://github.com/knative/serving/blob/master/cmd/queue/main.go
https://github.com/knative/serving/blob/master/pkg/reconciler/v1alpha1/revision/resources/queue.go
https://github.com/knative/serving/blob/master/pkg/reconciler/v1alpha1/revision/resources/deploy.go

[tcnghia]

In recent PR @yanweiguo added port 9090, which should be handled similarly.

[tcnghia]

@dgerd can this issue be closed now that we don't allow conflict? may be a different issue is to randomize ports to give users more flexibility on what ports they can use.

[dgerd]

This is the later. This is to randomize ports to give users more flexibility on the ports they choose.

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale