Don't allow port to conflict with QueueProxy#2753
Don't allow port to conflict with QueueProxy#2753knative-prow-robot merged 2 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
the
size/S
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@dgerd: 0 warnings.
Details
In response to this:
This change prevents the user from choosing ports 8012 nad 8022 as they
are currently reserved by the QueueProxy sidecar container.Fixes #
Proposed Changes
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/assign mattmoor |
|
/test pull-knative-serving-integration-tests |
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
/approve
Leaving LGTM to someone else, as I don't know what else has been considered.
knative-prow-robot
added
the
approved
mattmoor
added
kind/bug
This change prevents the user from choosing ports 8012 nad 8022 as they are currently reserved by the QueueProxy sidecar container. Ref knative#2752 Ref knative#2642
dgerd
force-pushed
the
restrict-queue-proxy-ports
branch
from
ee31b02 to
a32d17b
Compare
knative-prow-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradhoekstra, dgerd, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on pkg/.
|
8 participants
This change prevents the user from choosing ports 8012 nad 8022 as they
are currently reserved by the QueueProxy sidecar container.
Ref #2752
Ref #2642