Add e2e test for creating a service with ImagePullSecrets

[taragu]

/area API
/area test-and-release

As part of #5866, we need to add an e2e test for creating a service with ImagePullSecrets after #5917 is merged.

/assign
FYI @dgerd

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[markusthoemmes]

@taragu are you still working on this? If so, please remove the stale status.

[taragu]

/remove-lifecycle stale

[taragu]

I'm trying to construct the e2e test for creating a service with an image of a private registry. However, I'm running into a problem. It seems the only way to create a docker registry secret is with plain username and password (https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#-em-secret-docker-registry-em-), and we shouldn't have those information in any of our e2e tests or scripts. Does anyone know a workaround for this problem?

[karlkfi]

You can use a GCR _json_key in a docker registry secret, but it will also be in clear text (it gets base64 encoded). To make docker use a _json_key you use _json_key as the username and the keyfile json as the password.
https://cloud.google.com/container-registry/docs/advanced-authentication#json-key

For an e2e test, tho, you'll probably want to deploy a local disposable private registry and generate credentials for it on-demand when you set up the test.
https://docs.docker.com/registry/deploying/#native-basic-auth

[taragu]

@karlkfi thanks for your suggestion!
/unassign
I currently don't have the bandwidth for this. Anyone else please feel free to pick up this issue.

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale