Move the Route controllers "mark" methods into _types.go.#1113
Move the Route controllers "mark" methods into _types.go.#1113google-prow-robot merged 1 commit intoknative:masterfrom
_types.go.#1113Conversation
google-prow-robot
added
approved
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
| } | ||
|
|
||
| func (rs *RouteStatus) MarkTrafficNotAssigned(kind, name string) { | ||
| reason := kind + "Missing" |
There was a problem hiding this comment.
Nit: Doing this makes it difficult to grep for e.g. "RevisionMissing" if I'm trying to debug what's going on.
There was a problem hiding this comment.
(surfacing offline convo) We don't expect "Reason" to have limited cardinality, or this would be an enumeration and we'd simply pass in the appropriate constant (like "Type"). Ack the grep difficulty, but I'm biasing towards not duplicating such sparsely used code.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Move revision condition manipulation into revision_types.go This is the Revision equivalent of #1113 This contains two other unrelated changes: 1. Condense the object construction in `revision_test.go` 1. Reorder the `helloworld` yaml to create the configuration first. The reason for the second "unrelated" change is that I was seeing the route controller marking the Route as "AllTrafficAssigned = False" because the configuration wasn't created yet. * Update the conditions spec to eliminate wording about elision. Eliding conditions can come later, it's a premature optimization, and I'm not sure we're handling conditions well enough to do it reliably yet. * Fix test breakages due to setCondition becoming private. * Add unit test coverage of the condition logic. * Clarify isBuildDone through local variable names.
4 participants
No description provided.