Skip to content

Move service condition manipulation into _types.go#1135

Merged
google-prow-robot merged 1 commit into
knative:masterfrom
mattmoor:steve-conditions
Jun 11, 2018
Merged

Move service condition manipulation into _types.go#1135
google-prow-robot merged 1 commit into
knative:masterfrom
mattmoor:steve-conditions

Conversation

@mattmoor
Copy link
Copy Markdown
Member

@mattmoor mattmoor commented Jun 11, 2018

This is the Service equivalent of #1113, #1118, #1132

However, Service's condition are largely not implemented, so mostly deferred to: #1134

@google-prow-robot google-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2018
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 11, 2018

The following is the coverage report on pkg/. Say /test pull-knative-serving-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/revision_types.go 82.8% 90.5% 7.7
pkg/apis/serving/v1alpha1/revision_types_test.go 82.8% 90.5% 7.7
pkg/apis/serving/v1alpha1/route_types.go 30.4% 85.0% 54.6
pkg/apis/serving/v1alpha1/route_types_test.go 30.4% 85.0% 54.6
pkg/apis/serving/v1alpha1/service_types.go 95.8% 96.4% 0.6
pkg/apis/serving/v1alpha1/service_types_test.go 95.8% 96.4% 0.6
pkg/apis/serving/v1alpha1/configuration_types.go 96.0% 97.4% 1.4
pkg/apis/serving/v1alpha1/configuration_types_test.go 96.0% 97.4% 1.4
pkg/controller/configuration/configuration.go 76.9% 73.9% -3.0
pkg/controller/configuration/configuration_test.go 76.9% 73.9% -3.0
pkg/controller/route/route.go 78.9% 78.8% -0.1
pkg/controller/revision/revision.go 74.8% 73.7% -1.2
pkg/controller/revision/revision_test.go 74.8% 73.7% -1.2

*TestCoverage feature is being tested, do not rely on any info here yet

@google-prow-robot google-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2018
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 11, 2018

The following is the coverage report on pkg/. Say /test pull-knative-serving-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/configuration_types.go 96.0% 97.4% 1.4
pkg/apis/serving/v1alpha1/configuration_types_test.go 96.0% 97.4% 1.4
pkg/apis/serving/v1alpha1/service_types.go 95.8% 96.4% 0.6
pkg/apis/serving/v1alpha1/service_types_test.go 95.8% 96.4% 0.6
pkg/controller/configuration/configuration.go 76.9% 73.9% -3.0
pkg/controller/configuration/configuration_test.go 76.9% 73.9% -3.0

*TestCoverage feature is being tested, do not rely on any info here yet

@mattmoor
Move service condition manipulation into _types.go
bb678b5 
This is the Service equivalent of #1113, #1118, #1132

However, Service's condition are largely not implemented, so mostly deferred to: knative/serving#1134
@google-prow-robot google-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 11, 2018
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 11, 2018

The following is the coverage report on pkg/. Say /test pull-knative-serving-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/service_types.go 95.8% 96.4% 0.6
pkg/apis/serving/v1alpha1/service_types_test.go 95.8% 96.4% 0.6

*TestCoverage feature is being tested, do not rely on any info here yet

@mattmoor mattmoor changed the title [WIP] Move service condition manipulation into _types.go Move service condition manipulation into _types.go Jun 11, 2018
@google-prow-robot google-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2018
tcnghia
tcnghia approved these changes Jun 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2018
@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jun 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot merged commit 2fc4269 into knative:master Jun 11, 2018
dsimansk pushed a commit to dsimansk/serving that referenced this pull request Feb 18, 2025
@creydr
Merge pull request knative#1135 from serverless-qe/sync-konflux-relea…
c566a8f 
…se-v1.15

[release-v1.15] Update Konflux configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tcnghia tcnghia tcnghia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

@jonjohnsonjr jonjohnsonjr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattmoor @knative-metrics-robot @google-prow-robot @tcnghia @jonjohnsonjr